Re: [RFC][PATCH v4] emacs: Re-implement advance/rewind functions of notmuch-show...

diff --git a/00/5df8fda01a480a94a4b9fcb13d7ae5a23c3df7 b/00/5df8fda01a480a94a4b9fcb13d7ae5a23c3df7
new file mode 100644 (file)
index 0000000..bc753d7
--- /dev/null
+++ b/00/5df8fda01a480a94a4b9fcb13d7ae5a23c3df7
@@ -0,0 +1,109 @@
+Return-Path: <dme@dme.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8971D431FD0\r
+       for <notmuch@notmuchmail.org>; Mon, 26 Dec 2011 02:49:51 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id vBRIun7hPbZd for <notmuch@notmuchmail.org>;\r
+       Mon, 26 Dec 2011 02:49:51 -0800 (PST)\r
+Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com\r
+       [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 06DC6431FB6\r
+       for <notmuch@notmuchmail.org>; Mon, 26 Dec 2011 02:49:50 -0800 (PST)\r
+Received: by wibhq2 with SMTP id hq2so5282754wib.26\r
+       for <notmuch@notmuchmail.org>; Mon, 26 Dec 2011 02:49:49 -0800 (PST)\r
+Received: by 10.180.19.74 with SMTP id c10mr52515570wie.8.1324896589731;\r
+       Mon, 26 Dec 2011 02:49:49 -0800 (PST)\r
+Received: from hotblack-desiato.hh.sledj.net\r
+       (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25])\r
+       by mx.google.com with ESMTPS id dd4sm56011531wib.1.2011.12.26.02.49.47\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Mon, 26 Dec 2011 02:49:48 -0800 (PST)\r
+Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000)\r
+       id 9609CA0765; Mon, 26 Dec 2011 10:49:46 +0000 (GMT)\r
+To: Austin Clements <amdragon@MIT.EDU>\r
+Subject: Re: [RFC][PATCH v4] emacs: Re-implement advance/rewind functions of\r
+       notmuch-show-mode.\r
+In-Reply-To: <20111225010635.GG1927@mit.edu>\r
+References: <id:"1324553312-10972-1-git-send-email-dme@dme.org">\r
+       <1324665712-2419-1-git-send-email-dme@dme.org>\r
+       <20111225010635.GG1927@mit.edu>\r
+User-Agent: Notmuch/0.10.2+107~ga2d0215 (http://notmuchmail.org)\r
+       Emacs/24.0.92.1 (x86_64-pc-linux-gnu)\r
+From: David Edmondson <dme@dme.org>\r
+Date: Mon, 26 Dec 2011 10:49:46 +0000\r
+Message-ID: <cunlipztxo5.fsf@hotblack-desiato.hh.sledj.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 26 Dec 2011 10:49:51 -0000\r
+\r
+--=-=-=\r
+Content-Type: text/plain\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Sat, 24 Dec 2011 20:06:35 -0500, Austin Clements <amdragon@MIT.EDU> wrot=\r
+e:\r
+> Awesome.  This looks significantly cleaner.  I think this is worth\r
+> pushing for the comment you added to notmuch-show-advance alone.\r
+\r
+Thanks.\r
+\r
+> This definitely changes the behavior of rewind, but other than one\r
+> case I point out below, I think what you have now is much closer to an\r
+> inverse of advance.  It would be nice to have tests for rewind (looks\r
+> like we don't have any right now), but it would seem counterproductive\r
+> to write tests for the current rewind only to rewrite them for this\r
+> rewind.\r
+\r
+I'll write some tests.\r
+\r
+> Tailing whitespace.\r
+\r
+Will fix.\r
+\r
+> > +     ((=3D start-of-message (point))\r
+> > +      ;; The cursor is at the start of the current message - move to\r
+> > +      ;; the previous open message.\r
+> > +      (notmuch-show-previous-open-message))\r
+>=20\r
+> This will jump to the beginning of the previous message if I'm at the\r
+> beginning of a message.  I would expect rewind to show me the end of\r
+> the previous message in this case.\r
+\r
+That would definitely more closely be the inverse of how advance works,\r
+but is it the most useful behaviour?\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iEYEARECAAYFAk74UUoACgkQaezQq/BJZRY0EgCfTd7GM9CehP0QMraC/KeIQ11m\r
+o8wAnAygHiD2jJddvPaV19dgetFmcGuU\r
+=Gyn2\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r