Re: [PATCH] go: Update to the current notmuch_database_find_message API

diff --git a/2c/39146a12ffb6e192d72a6055350ceec9258c9d b/2c/39146a12ffb6e192d72a6055350ceec9258c9d
new file mode 100644 (file)
index 0000000..ad015e7
--- /dev/null
+++ b/2c/39146a12ffb6e192d72a6055350ceec9258c9d
@@ -0,0 +1,72 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 4C369431FAF\r
+       for <notmuch@notmuchmail.org>; Mon, 30 Apr 2012 04:53:59 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id gKDuIqJOFgIy for <notmuch@notmuchmail.org>;\r
+       Mon, 30 Apr 2012 04:53:58 -0700 (PDT)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id B5821431FAE\r
+       for <notmuch@notmuchmail.org>; Mon, 30 Apr 2012 04:53:58 -0700 (PDT)\r
+Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([156.34.89.108] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32)\r
+       (Exim 4.72) (envelope-from <bremner@unb.ca>)\r
+       id 1SOpAw-0004ba-8R; Mon, 30 Apr 2012 08:53:54 -0300\r
+Received: from bremner by zancas.localnet with local (Exim 4.77)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1SOpAp-0004vR-Cc; Mon, 30 Apr 2012 08:53:47 -0300\r
+From: David Bremner <david@tethera.net>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] go: Update to the current notmuch_database_find_message\r
+       API\r
+In-Reply-To: <1335649518-1970-1-git-send-email-amdragon@mit.edu>\r
+References: <1335649518-1970-1-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.12+152~g904a807 (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Mon, 30 Apr 2012 08:53:47 -0300\r
+Message-ID: <87lildph9w.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 30 Apr 2012 11:53:59 -0000\r
+\r
+Austin Clements <amdragon@MIT.EDU> writes:\r
+\r
+> The signature of notmuch_database_find_message was changed in 02a30767\r
+> to report errors and the Go bindings were never updated.  This brings\r
+> the Go bindings in sync with that change and at least makes them\r
+> compile with Go r60.3, the last release before Go 1.\r
+\r
+I don't have any easy way to test this, since the current versions in \r
+Debian are all based on Go 1.  On the other hand I guess it doesn't make\r
+things worse.  Anybody have any objections to this patch?\r
+\r
+In the long run we have to decide what to do about these bindings. Seb\r
+(or anyone else) are you interested in porting them to Go 1 and\r
+maintaining them?  Otherwise it may be time to deprecate them.\r
+\r
+d\r