Re: [PATCH v2] emacs: jump: sort-order bugfix

diff --git a/86/d03c4df6f26a6db701716ea862e9b1b9fb1f5d b/86/d03c4df6f26a6db701716ea862e9b1b9fb1f5d
new file mode 100644 (file)
index 0000000..b1bdaf7
--- /dev/null
+++ b/86/d03c4df6f26a6db701716ea862e9b1b9fb1f5d
@@ -0,0 +1,135 @@
+Return-Path: <aclements@csail.mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 0B30C431FB6\r
+       for <notmuch@notmuchmail.org>; Tue,  2 Sep 2014 12:27:32 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 6-c+m+xBE2ic for <notmuch@notmuchmail.org>;\r
+       Tue,  2 Sep 2014 12:27:28 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-3.mit.edu (dmz-mailsec-scanner-3.mit.edu\r
+       [18.9.25.14])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 70A4A431FAF\r
+       for <notmuch@notmuchmail.org>; Tue,  2 Sep 2014 12:27:28 -0700 (PDT)\r
+X-AuditID: 1209190e-f79d46d000003643-d0-54061a1e6189\r
+Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])\r
+       (using TLS with cipher AES256-SHA (256/256 bits))\r
+       (Client did not present a certificate)\r
+       by dmz-mailsec-scanner-3.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id 4B.9D.13891.E1A16045; Tue,  2 Sep 2014 15:27:26 -0400 (EDT)\r
+Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\r
+       by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id s82JRPSD014262; \r
+       Tue, 2 Sep 2014 15:27:26 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id s82JRNl4014444\r
+       (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
+       Tue, 2 Sep 2014 15:27:24 -0400\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
+       (envelope-from <aclements@csail.mit.edu>)\r
+       id 1XOtje-0003ck-Ve; Tue, 02 Sep 2014 15:27:23 -0400\r
+Date: Tue, 2 Sep 2014 15:27:22 -0400\r
+From: Austin Clements <aclements@csail.mit.edu>\r
+To: Mark Walters <markwalters1009@gmail.com>\r
+Subject: Re: [PATCH v2] emacs: jump: sort-order bugfix\r
+Message-ID: <20140902192722.GC4977@csail.mit.edu>\r
+References: <1409661049-23417-1-git-send-email-markwalters1009@gmail.com>\r
+       <1409684164-28407-1-git-send-email-markwalters1009@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <1409684164-28407-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFupjleLIzCtJLcpLzFFi42IR4hRV1pWTYgsxmPNDzGL1XB6L6zdnMjsw\r
+       eeycdZfd49mqW8wBTFFcNimpOZllqUX6dglcGaunHGIu2MJbMe3bHsYGxg1cXYwcHBICJhLL\r
+       5yh2MXICmWISF+6tZ+ti5OIQEpjNJHFu7wEoZwOjxJwjr6CcU0wSG/Z8ZIVwVjNK3O38xwTS\r
+       zyKgItH8dR2YzSagL7Fi7SRWEFtEQEfi9qEF7CA2s4C0xLffzWA1wgJmEieeP2MBsXkFDCU+\r
+       TzjKCDG0k1Hi5ddOdoiEoMTJmU9YIJq1JG78e8kEcjfIoOX/OEBMTgEviXdrykAqRIFOmHJy\r
+       G9sERqFZSJpnIWmehdC8gJF5FaNsSm6Vbm5iZk5xarJucXJiXl5qka6xXm5miV5qSukmRnBQ\r
+       S/LtYPx6UOkQowAHoxIPr8QPlhAh1sSy4srcQ4ySHExKorw8ImwhQnxJ+SmVGYnFGfFFpTmp\r
+       xYcYJTiYlUR4nb+yhgjxpiRWVqUW5cOkpDlYlMR531pbBQsJpCeWpGanphakFsFkZTg4lCR4\r
+       gyWBhgoWpaanVqRl5pQgpJk4OEGG8wANbwGp4S0uSMwtzkyHyJ9i1OVY1/mtn0mIJS8/L1VK\r
+       nLcWpEgApCijNA9uDiwZvWIUB3pLmLcbpIoHmMjgJr0CWsIEtMQtB+SD4pJEhJRUA6N7gPN0\r
+       zricmNvbwxQmfLJm3fFj5818m7PX1lkpf1km1FbK1CO9mnfl6qu2FxdvUd+c9OVz7aa91bG9\r
+       P3a0llxwEBLmct5k8GH9rMh3Us1TVWYL567jFd66doW1l6CgxdPby0rPWF00kf7T8sxal3H3\r
+       JeGDThMdOkq632yv/MrwjnFLqO6VskNKLMUZiYZazEXFiQCX0DWFIQMAAA==\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 02 Sep 2014 19:27:32 -0000\r
+\r
+LGTM.\r
+\r
+Quoth Mark Walters on Sep 02 at  7:56 pm:\r
+> default-value needs its argument to be quoted.\r
+> \r
+> Slightly strangely default-value of 't or nil is 't or nil\r
+> respectively so the code\r
+> \r
+> (default-value notmuch-search-oldest-first)\r
+> \r
+> just gives the current value of notmuch-search-oldest-first rather\r
+> than intended default-value of this variable.\r
+> \r
+> The symptom is that if you are in a search buffer and use notmuch jump\r
+> to run a saved search which does not have an explicitly set sort order\r
+> then the sort order of the saved-search is inherited from the current\r
+> search buffer rather than being the default search order.\r
+> \r
+> Thanks to Jani for finding the bug.\r
+> ---\r
+> \r
+> This time with a fuller commit message.\r
+> \r
+> (Part of the reason I did not send more before is I had not checked\r
+> what the exact outcome of the buggy code was: it was obvious what the\r
+> code was intended to do, and that with the extra quote it\r
+> would do what it was intended to do.)\r
+> \r
+> Best wishes\r
+> \r
+> Mark\r
+> \r
+> \r
+> \r
+> \r
+> \r
+> \r
+> \r
+>  emacs/notmuch-jump.el |    2 +-\r
+>  1 file changed, 1 insertion(+), 1 deletion(-)\r
+> \r
+> diff --git a/emacs/notmuch-jump.el b/emacs/notmuch-jump.el\r
+> index 5eb0949..0193f8c 100644\r
+> --- a/emacs/notmuch-jump.el\r
+> +++ b/emacs/notmuch-jump.el\r
+> @@ -51,7 +51,7 @@ (defun notmuch-jump-search ()\r
+>               (case (plist-get saved-search :sort-order)\r
+>                 (newest-first nil)\r
+>                 (oldest-first t)\r
+> -               (otherwise (default-value notmuch-search-oldest-first)))))\r
+> +               (otherwise (default-value 'notmuch-search-oldest-first)))))\r
+>          (push (list key name\r
+>                      `(lambda () (notmuch-search ',query ',oldest-first)))\r
+>                action-map)))))\r