Re: [PATCH] emacs: add buttons for all multipart/related parts

diff --git a/15/7abb967eb055a2f6122831a4e7d593024448f3 b/15/7abb967eb055a2f6122831a4e7d593024448f3
new file mode 100644 (file)
index 0000000..d468722
--- /dev/null
+++ b/15/7abb967eb055a2f6122831a4e7d593024448f3
@@ -0,0 +1,107 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id F34C2431FC2\r
+       for <notmuch@notmuchmail.org>; Fri, 23 Aug 2013 01:37:10 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 1.401\r
+X-Spam-Level: *\r
+X-Spam-Status: No, score=1.401 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       FREEMAIL_REPLY=2.499, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id CNbk3HRYZTtp for <notmuch@notmuchmail.org>;\r
+       Fri, 23 Aug 2013 01:37:05 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 0D093431FAE\r
+       for <notmuch@notmuchmail.org>; Fri, 23 Aug 2013 01:37:05 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1VCmrT-0001ci-0R; Fri, 23 Aug 2013 09:36:55 +0100\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1VCmrS-00012V-OV; Fri, 23 Aug 2013 09:36:50 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>,\r
+       Istvan Marko <notmuch@kismala.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: add buttons for all multipart/related parts\r
+In-Reply-To: <87fvu4fl25.fsf@servo.finestructure.net>\r
+References: <m3r4dtgz9k.fsf@zsu.kismala.com>\r
+       <87fvu4fl25.fsf@servo.finestructure.net>\r
+User-Agent: Notmuch/0.15.2+192~g8222af3 (http://notmuchmail.org) Emacs/23.4.1\r
+       (i486-pc-linux-gnu)\r
+Date: Fri, 23 Aug 2013 09:36:49 +0100\r
+Message-ID: <87d2p44xcu.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: 7cedcee375505232f81e04db53dd705d (of first 20000 bytes)\r
+X-SpamAssassin-Score: 0.6\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored 0.6 points. Summary of the scoring: \r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       *  1.0 FREEMAIL_REPLY From and body contain different freemails\r
+       * -0.4 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 23 Aug 2013 08:37:11 -0000\r
+\r
+\r
+Jameson Graef Rollins <jrollins@finestructure.net> writes:\r
+\r
+> On Fri, Aug 16 2013, Istvan Marko <notmuch@kismala.com> wrote:\r
+>> When text/html parts include images as multipart/related and the\r
+>> text/plain alternative is used these images can be completely hidden\r
+>> with no easy way to access them or even find out that they are there.\r
+>>\r
+>> Make notmuch-show-insert-part-multipart/related add buttons for all\r
+>> parts, the first one visible the rest hidden.\r
+>\r
+> Hey, Istvan.  Thanks so much for this patch.  It seems to be addressing\r
+> the same issue I reported in id:87ob8u8l6k.fsf@servo.finestructure.net.\r
+>\r
+> However, the behavior of the part button that now appears seems to be a\r
+> bit strange.  Clicking/hitting enter on the part attempts to save it\r
+> rather than open it.  I wouldn't be surprised if has nothing to do with\r
+> the correctness of this patch, though.  So is it possible that the\r
+> button is not inserted in the most ideal way, or is there some other\r
+> issue preventing it from behaving properly (could it have to do with the\r
+> part being "inline"?)?\r
+\r
+\r
+Hi\r
+\r
+I think I have diagnosed this bug. There is a potential fix in\r
+id:1377246875-7784-1-git-send-email-markwalters1009@gmail.com \r
+\r
+The bug is nothing to do with Istvan's patch: his patch just triggers the\r
+underlying bug in the lazy part handling.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r