--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 6CE56431FC2\r
+ for <notmuch@notmuchmail.org>; Sun, 21 Jul 2013 01:36:48 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 1.401\r
+X-Spam-Level: *\r
+X-Spam-Status: No, score=1.401 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ FREEMAIL_REPLY=2.499, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3]\r
+ autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id Yy6I6E2970gC for <notmuch@notmuchmail.org>;\r
+ Sun, 21 Jul 2013 01:36:41 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 0CBB5431FB6\r
+ for <notmuch@notmuchmail.org>; Sun, 21 Jul 2013 01:36:41 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1V0p8B-0006BQ-6j; Sun, 21 Jul 2013 09:36:39 +0100\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1V0p8A-0002hH-Sg; Sun, 21 Jul 2013 09:36:39 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 00/11] contrib: pick: keybindings\r
+In-Reply-To: <m2ppuwt7db.fsf@guru.guru-group.fi>\r
+References: <1373047878-20822-1-git-send-email-markwalters1009@gmail.com>\r
+ <m2ppuwt7db.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.15.2+192~g8222af3 (http://notmuchmail.org) Emacs/23.4.1\r
+ (i486-pc-linux-gnu)\r
+Date: Sun, 21 Jul 2013 09:36:38 +0100\r
+Message-ID: <87ehas8g2x.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: 6ad08e95498472513f982c37411e7c70 (of first 20000 bytes)\r
+X-SpamAssassin-Score: 0.6\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored 0.6 points. Summary of the scoring: \r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * 1.0 FREEMAIL_REPLY From and body contain different freemails\r
+ * -0.4 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 21 Jul 2013 08:36:48 -0000\r
+\r
+Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+\r
+> On Fri, Jul 05 2013, Mark Walters <markwalters1009@gmail.com> wrote:\r
+>\r
+>> This series adds lots of keybindings and funtionality to pick: in\r
+>> particular it adds the stash keymap, the ability to tab between and\r
+>> activate buttons in the message pane, and it reduces a lot of code\r
+>> duplication between pick and show.\r
+>>\r
+>> It is a large series: but most of it is a lot of small changes. These\r
+>> small changes are mostly logically independent but as they add\r
+>> keybindings their contexts all clash. I have made most of the\r
+>> keybindings as single separate patches to make discussion of them\r
+>> individually easier.\r
+>>\r
+>> The key patches for review/discussion (apart from bike-shedding on\r
+>> key-bindings!) are patches 1, 5 and 8.\r
+\r
+Hi \r
+\r
+Thanks for the review.\r
+\r
+> Now that you "asked", I'd ask what was used as a reason to decide "/"\r
+> as keybinding for notmuch-pick-button-activate -- something common\r
+> or as a convenience. In US/UK keyboard "/" is left to Right Shift,\r
+> but for example in my keyboard it is Shift-7...\r
+\r
+That is just my not knowing (and I regret to say even thinking of) other\r
+keyboard layouts. I agree that makes it a silly key. What about 'e'\r
+(Enter as the mnemonic)?\r
+>\r
+>> Patch 1 is the most "controversial": it over-rides\r
+>> notmuch-show-get-prop so that whether it uses\r
+>> notmuch-show-get-message-properties or\r
+>> notmuch-pick-get-message-properties depends on the major-mode (ie\r
+>> whether it is called from pick or show).\r
+>\r
+> At the moment the code comments could have something like XXX to\r
+> emphasize the situation. IMHO it is ok to have this in contrib\r
+> code -- when this is going to be "official" part of emacs MUA\r
+> then this code needs to be ... well, at least moved to other place :D\r
+\r
+Yes that is a good point. I will add this in the next version.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+> Apart from these code LGTM.\r
+>\r
+> Tomi\r
+>\r
+>\r
+>> This means that functions from show which just use message properties\r
+>> (most often just the message id) "just work" when called from pick. In\r
+>> particular it gives us access to lots of functions without having to\r
+>> duplicate the code.\r
+>>\r
+>> In the longer term it would be better to have some show/pick common\r
+>> file and migrate the common functions there.\r
+>>\r
+>> Patch 5 and 8 add in functions for creating fucntions ready to be used\r
+>> in keybindings. The one in patch 5 takes a show fucntion and creates a\r
+>> function which switches from pick to the message pane, applies the\r
+>> function and then switches back to pick. The one in patch 8 takes a\r
+>> function and creates a function which closes the message pane and the\r
+>> calls this function.\r
+>>\r
+>> Both of these make the keybinding section clearer. They also have the\r
+>> advantage that the user can use them easily to create their own\r
+>> keybindings which do this.\r
+>>\r
+>> This completes all the keybindings I use and I think means that pick\r
+>> doesn't have any glaring omissions.\r
+>>\r
+>> Finally, this will clash with the thread archive patches\r
+>> id:1371195472-441-1-git-send-email-markwalters1009@gmail.com\r
+>>\r
+>> Best wishes\r
+>>\r
+>> Mark\r
+>>\r
+>> Mark Walters (11):\r
+>> contrib: pick: override notmuch-show-get-prop\r
+>> contrib: pick: Link in notmuch-show-pipe-message\r
+>> contrib: pick: Link in attachment functions straight from\r
+>> notmuch-show\r
+>> contrib: pick: Link in stash map straight from notmuch-show\r
+>> contrib: pick: add in to-message-window function\r
+>> contrib: pick: add button press helper\r
+>> contrib: pick: pass tab through to the message pane\r
+>> contrib: pick: close window function\r
+>> contrib: pick: make help close the message pane first\r
+>> contrib: pick: add in binding to view raw message\r
+>> contrib: pick: use close-message-pane for reply etc\r
+>>\r
+>> contrib/notmuch-pick/notmuch-pick.el | 139 +++++++++++++++++-----------------\r
+>> 1 files changed, 70 insertions(+), 69 deletions(-)\r
+>>\r
+>> -- \r
+>> 1.7.9.1\r
+>>\r
+>> _______________________________________________\r
+>> notmuch mailing list\r
+>> notmuch@notmuchmail.org\r
+>> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff