Re: [PATCH 3/4] test: sanitize dates in emacs, raw, and text output

diff --git a/88/f5923c6a1f171dfc2e7c3bf2f8d974a07dd812 b/88/f5923c6a1f171dfc2e7c3bf2f8d974a07dd812
new file mode 100644 (file)
index 0000000..417f245
--- /dev/null
+++ b/88/f5923c6a1f171dfc2e7c3bf2f8d974a07dd812
@@ -0,0 +1,75 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 20968431FCB\r
+       for <notmuch@notmuchmail.org>; Sun,  8 Dec 2013 17:18:15 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id b6EoFEi+lvTw for <notmuch@notmuchmail.org>;\r
+       Sun,  8 Dec 2013 17:17:52 -0800 (PST)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 23BA2431FC3\r
+       for <notmuch@notmuchmail.org>; Sun,  8 Dec 2013 17:17:52 -0800 (PST)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1VppTo-0000a2-Qw; Sun, 08 Dec 2013 21:17:48 -0400\r
+Received: (nullmailer pid 22711 invoked by uid 1000); Mon, 09 Dec 2013\r
+       01:17:41 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Austin Clements <amdragon@MIT.EDU>\r
+Subject: Re: [PATCH 3/4] test: sanitize dates in emacs, raw, and text output\r
+In-Reply-To: <20131209002519.GH8854@mit.edu>\r
+References: <1386517946-22054-1-git-send-email-david@tethera.net>\r
+       <1386517946-22054-4-git-send-email-david@tethera.net>\r
+       <20131209002519.GH8854@mit.edu>\r
+User-Agent: Notmuch/0.17~rc3 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Mon, 09 Dec 2013 09:17:41 +0800\r
+Message-ID: <87ob4qlt56.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 09 Dec 2013 01:18:15 -0000\r
+\r
+Austin Clements <amdragon@MIT.EDU> writes:\r
+\r
+> This may be orthogonal to this series, but I don't get why we have\r
+> both notmuch_show_sanitize and notmuch_show_sanitize_all (especially\r
+> when the "all" version is not obviously a superset of the non-"all"\r
+> version!)  Do you have a sense for whether these two functions could\r
+> be easily merged?\r
+\r
+Yeah, I don't really understand the reason for these two functions\r
+either. I also discovered (and deleted) another duplicate file name\r
+sanitization function elsewhere in the series, so it wouldn't surprise\r
+me if it's just collective sloppiness.\r
+\r
+>\r
+> Rather than (nearly) duplicating the regexp, does it work to pipe this\r
+> through notmuch_date_sanitize?  Or do the minor differences matter?\r
+>\r
+\r
+I'll try this out.\r
+\r
+d\r