[PATCH 1/2] contrib: pick: remove unneeded variable notmuch-pick-buffer-name

diff --git a/74/ec96ce8378695c6ed20114eb75b47d9b8a377b b/74/ec96ce8378695c6ed20114eb75b47d9b8a377b
new file mode 100644 (file)
index 0000000..3012752
--- /dev/null
+++ b/74/ec96ce8378695c6ed20114eb75b47d9b8a377b
@@ -0,0 +1,130 @@
+Return-Path: <markwalters1009@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 2EC02429E2F\r
+       for <notmuch@notmuchmail.org>; Mon,  1 Jul 2013 14:07:56 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.201\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.201 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001,\r
+       RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id pJIBZ5PIMY2M for <notmuch@notmuchmail.org>;\r
+       Mon,  1 Jul 2013 14:07:48 -0700 (PDT)\r
+Received: from mail-wg0-f46.google.com (mail-wg0-f46.google.com\r
+ [74.125.82.46])       (using TLSv1 with cipher RC4-SHA (128/128 bits))        (No client\r
+ certificate requested)        by olra.theworths.org (Postfix) with ESMTPS id\r
+ 5BB33431FCF   for <notmuch@notmuchmail.org>; Mon,  1 Jul 2013 14:07:48 -0700\r
+ (PDT)\r
+Received: by mail-wg0-f46.google.com with SMTP id c11so4078028wgh.1\r
+       for <notmuch@notmuchmail.org>; Mon, 01 Jul 2013 14:07:47 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references;\r
+       bh=uxMHSMeBZOVR5cdFB77ntLQJ0xh77XxD9LtHj0stMcM=;\r
+       b=QHSwW4tUsMVjfokM04u/Sg7vUMv4XWhbPDugRgub27yYTV6pIuEZw1bTKo8XXGgprJ\r
+       DzKuVh4F4QuDyIe1aLAi5MYp/z9qGbK8KfQPhAw5OQppMr59c99V9XWS4pasVmkql1O3\r
+       QZ7pHlX9HcxuJe9QiwkA8j2O8yk52+7R59q4j3ZMSNzEjePZDTNIe2m40mmnYf9TI3JQ\r
+       r2W5WnWU2seZ1X8QwEXwwOeIIdl2+hDfUvpx3V5YwQi7ExcVtjf1z+/0wqwIgGR3cMal\r
+       Roo05NwRw0H2tXn74OcfZmTt+NifLFwUkcd4subQ65N0gwFbimYhAiDuzryB77AbmJ7I\r
+       WTcw==\r
+X-Received: by 10.194.249.69 with SMTP id ys5mr22272912wjc.39.1372712867286;\r
+       Mon, 01 Jul 2013 14:07:47 -0700 (PDT)\r
+Received: from localhost (93-97-24-31.zone5.bethere.co.uk. [93.97.24.31])\r
+       by mx.google.com with ESMTPSA id\r
+       fd3sm18842913wic.10.2013.07.01.14.07.46 for <multiple recipients>\r
+       (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+       Mon, 01 Jul 2013 14:07:46 -0700 (PDT)\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH 1/2] contrib: pick: remove unneeded variable\r
+       notmuch-pick-buffer-name\r
+Date: Mon,  1 Jul 2013 22:07:40 +0100\r
+Message-Id: <1372712861-13515-2-git-send-email-markwalters1009@gmail.com>\r
+X-Mailer: git-send-email 1.7.9.1\r
+In-Reply-To: <1372712861-13515-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1372712861-13515-1-git-send-email-markwalters1009@gmail.com>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 01 Jul 2013 21:07:56 -0000\r
+\r
+This variable is essentially unused: it was only used for making sure\r
+it itself got reset after a refresh of the buffer.\r
+\r
+It did this by passing an unnecessary argument to notmuch-pick-worker\r
+so remove that too.\r
+---\r
+ contrib/notmuch-pick/notmuch-pick.el |   15 ++++-----------\r
+ 1 files changed, 4 insertions(+), 11 deletions(-)\r
+\r
+diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el\r
+index fbd7c0b..ce627db 100644\r
+--- a/contrib/notmuch-pick/notmuch-pick.el\r
++++ b/contrib/notmuch-pick/notmuch-pick.el\r
+@@ -166,10 +166,6 @@\r
+   "A buffer local copy of argument open-target to the function notmuch-pick")\r
+ (make-variable-buffer-local 'notmuch-pick-open-target)\r
+ \r
+-(defvar notmuch-pick-buffer-name nil\r
+-  "A buffer local copy of argument buffer-name to the function notmuch-pick")\r
+-(make-variable-buffer-local 'notmuch-pick-buffer-name)\r
+-\r
+ (defvar notmuch-pick-message-window nil\r
+   "The window of the message pane.\r
+ \r
+@@ -527,13 +523,11 @@ message will be \"unarchived\", i.e. the tag changes in\r
+   (let ((inhibit-read-only t)\r
+       (basic-query notmuch-pick-basic-query)\r
+       (query-context notmuch-pick-query-context)\r
+-      (target (notmuch-pick-get-message-id))\r
+-      (buffer-name notmuch-pick-buffer-name))\r
++      (target (notmuch-pick-get-message-id)))\r
+     (erase-buffer)\r
+     (notmuch-pick-worker basic-query\r
+                        query-context\r
+-                       target\r
+-                       (get-buffer buffer-name))))\r
++                       target)))\r
+ \r
+ (defmacro with-current-notmuch-pick-message (&rest body)\r
+   "Evaluate body with current buffer set to the text of current message"\r
+@@ -799,12 +793,11 @@ Complete list of currently available key bindings:\r
+       (notmuch-sexp-parse-partial-list 'notmuch-pick-insert-forest-thread\r
+                                        results-buf)))))\r
+ \r
+-(defun notmuch-pick-worker (basic-query &optional query-context target buffer open-target)\r
++(defun notmuch-pick-worker (basic-query &optional query-context target open-target)\r
+   (interactive)\r
+   (notmuch-pick-mode)\r
+   (setq notmuch-pick-basic-query basic-query)\r
+   (setq notmuch-pick-query-context query-context)\r
+-  (setq notmuch-pick-buffer-name (buffer-name buffer))\r
+   (setq notmuch-pick-target-msg target)\r
+   (setq notmuch-pick-open-target open-target)\r
+ \r
+@@ -864,7 +857,7 @@ The arguments are:\r
+     ;; Don't track undo information for this buffer\r
+     (set 'buffer-undo-list t)\r
+ \r
+-    (notmuch-pick-worker query query-context target buffer open-target)\r
++    (notmuch-pick-worker query query-context target open-target)\r
+ \r
+     (setq truncate-lines t)))\r
+ \r
+-- \r
+1.7.9.1\r
+\r