--- /dev/null
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 129D3431FBD\r
+ for <notmuch@notmuchmail.org>; Thu, 24 Oct 2013 14:30:44 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id iW1lXEqfhnI7 for <notmuch@notmuchmail.org>;\r
+ Thu, 24 Oct 2013 14:30:35 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-7.mit.edu (dmz-mailsec-scanner-7.mit.edu\r
+ [18.7.68.36])\r
+ by olra.theworths.org (Postfix) with ESMTP id B9C76431FB6\r
+ for <notmuch@notmuchmail.org>; Thu, 24 Oct 2013 14:30:35 -0700 (PDT)\r
+X-AuditID: 12074424-b7f528e0000009aa-11-5269917ad005\r
+Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
+ by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP\r
+ id 2F.11.02474.A7199625; Thu, 24 Oct 2013 17:30:34 -0400 (EDT)\r
+Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\r
+ by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id r9OLUWNK015937; \r
+ Thu, 24 Oct 2013 17:30:32 -0400\r
+Received: from drake.dyndns.org (26-4-172.dynamic.csail.mit.edu [18.26.4.172])\r
+ (authenticated bits=0)\r
+ (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+ by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r9OLUUar007115\r
+ (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+ Thu, 24 Oct 2013 17:30:31 -0400\r
+Received: from amthrax by drake.dyndns.org with local (Exim 4.77)\r
+ (envelope-from <amdragon@mit.edu>)\r
+ id 1VZSUA-00017l-R9; Thu, 24 Oct 2013 17:30:30 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH] emacs: Add a space after completed tag operations\r
+Date: Thu, 24 Oct 2013 17:30:27 -0400\r
+Message-Id: <1382650227-4055-1-git-send-email-amdragon@mit.edu>\r
+X-Mailer: git-send-email 1.8.4.rc3\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFprFIsWRmVeSWpSXmKPExsUixCmqrVs1MTPIYPtnbovrN2cyOzB6PFt1\r
+ izmAMYrLJiU1J7MstUjfLoErY+6m2ywFK/grfj+QbmA8wtPFyMkhIWAi0XRuOjOELSZx4d56\r
+ ti5GLg4hgX2MEntfTmKEcDYySnS++8MC4Rxhkpj7aCZU2VxGiYbv65hA+tkENCS27V/OCGKL\r
+ CEhL7Lw7m7WLkYODWUBN4k+XCkhYWMBJ4vHMj2DrWARUJU7NXcMOYvMK2Eu87FjCCnGGksTC\r
+ U9tYJzDyLmBkWMUom5JbpZubmJlTnJqsW5ycmJeXWqRrrpebWaKXmlK6iREUBOwuKjsYmw8p\r
+ HWIU4GBU4uHV+JAeJMSaWFZcmXuIUZKDSUmUt29CZpAQX1J+SmVGYnFGfFFpTmrxIUYJDmYl\r
+ Ed5pekA53pTEyqrUonyYlDQHi5I47y0O+yAhgfTEktTs1NSC1CKYrAwHh5IE706QoYJFqemp\r
+ FWmZOSUIaSYOTpDhPEDDD4PU8BYXJOYWZ6ZD5E8xKkqJ88qAJARAEhmleXC9sCh9xSgO9Iow\r
+ 7y2QKh5ghMN1vwIazAQ0eMqSNJDBJYkIKakGxvk/n31949rBWK3zadfxPeu+1IXM5p7z/Gjz\r
+ nSuG7hanywvits9hMDoqXe2ULcW8Yb5o0mTOsFWbv1rzKZ4SOa+kobx39626IyuSmB+tlI4U\r
+ O/qmqVb3Ms/yV0lvp6v/kEr9P0F+XfhcB+H49Vdup/tE1b1d+X/fyXOBF7ZlXqnNcJJfJyrT\r
+ uUOJpTgj0VCLuag4EQAfRzrrrQIAAA==\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 24 Oct 2013 21:30:44 -0000\r
+\r
+Previously, when a user fully completed a tag operation, they had to\r
+press space to begin entering another tag operation. This is\r
+different from, say, shell file name completion, which typically\r
+inserts a space after an unambiguous completion under the assumption\r
+that the user will want to enter more input.\r
+\r
+This patch tweaks `notmuch-read-tag-changes' to act more like shell\r
+file name completion: after an unambiguous tag completion, it now\r
+inserts a space, ready and waiting for another tagging operation from\r
+the user. This is backwards-compatible with old habits, since there's\r
+no harm in putting an extra space.\r
+---\r
+\r
+Just because of the context, this must be applied on top of the\r
+currently pending tag completion series\r
+id:"1382487721-31776-1-git-send-email-amdragon@mit.edu". The change\r
+itself should be otherwise independent.\r
+\r
+ emacs/notmuch-tag.el | 12 ++++++++++--\r
+ 1 file changed, 10 insertions(+), 2 deletions(-)\r
+\r
+diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el\r
+index 7b21006..8b921f1 100644\r
+--- a/emacs/notmuch-tag.el\r
++++ b/emacs/notmuch-tag.el\r
+@@ -229,8 +229,16 @@ initial input in the minibuffer."\r
+ (set-keymap-parent map crm-local-completion-map)\r
+ (define-key map " " 'self-insert-command)\r
+ map)))\r
+- (delete "" (completing-read-multiple prompt\r
+- tag-list nil nil initial-input\r
++ (delete "" (completing-read-multiple\r
++ prompt\r
++ ;; Append the separator to each completion so when the\r
++ ;; user completes a tag they can immediately begin\r
++ ;; entering another. `completing-read-multiple'\r
++ ;; ultimately splits the input on crm-separator, so we\r
++ ;; don't need to strip this back off (we just need to\r
++ ;; delete "empty" entries caused by trailing spaces).\r
++ (mapcar (lambda (tag-op) (concat tag-op crm-separator)) tag-list)\r
++ nil nil initial-input\r
+ 'notmuch-read-tag-changes-history))))\r
+ \r
+ (defun notmuch-update-tags (tags tag-changes)\r
+-- \r
+1.8.4.rc3\r
+\r
projects / notmuch-archives.git / commitdiff