Re: [PATCH] emacs: Fix regression in (notmuch-)message-mode initialization

diff --git a/e5/608751fcf9e9569441e6e80f47783a7dc93d13 b/e5/608751fcf9e9569441e6e80f47783a7dc93d13
new file mode 100644 (file)
index 0000000..cbcdf5e
--- /dev/null
+++ b/e5/608751fcf9e9569441e6e80f47783a7dc93d13
@@ -0,0 +1,81 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 8B4AD6DE1104\r
+ for <notmuch@notmuchmail.org>; Mon,  9 Nov 2015 04:18:53 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.095\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.095 tagged_above=-999 required=5 tests=[AWL=0.095]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id uJrmbH8EZxv4 for <notmuch@notmuchmail.org>;\r
+ Mon,  9 Nov 2015 04:18:51 -0800 (PST)\r
+Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 0703C6DE103A\r
+ for <notmuch@notmuchmail.org>; Mon,  9 Nov 2015 04:18:51 -0800 (PST)\r
+Received: from remotemail by gitolite.debian.net with local (Exim 4.80)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1ZvlOd-0005o5-83; Mon, 09 Nov 2015 12:18:03 +0000\r
+Received: (nullmailer pid 22982 invoked by uid 1000); Mon, 09 Nov 2015\r
+ 12:17:44 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: Fix regression in (notmuch-)message-mode\r
+ initialization\r
+In-Reply-To: <1446573161-28068-1-git-send-email-sojkam1@fel.cvut.cz>\r
+References: <1446573161-28068-1-git-send-email-sojkam1@fel.cvut.cz>\r
+User-Agent: Notmuch/0.21~rc3+7~g10e933a (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Mon, 09 Nov 2015 08:17:44 -0400\r
+Message-ID: <87d1vj4b9z.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 09 Nov 2015 12:18:53 -0000\r
+\r
+Michal Sojka <sojkam1@fel.cvut.cz> writes:\r
+\r
+> This commit uses advice mechanism to call notmuch-message-mode instead\r
+> of message-mode. This way, a call to message-mail initializes directly\r
+> notmuch-message-mode rather than message-mode which is later changed\r
+> to notmuch-message-mode. The advice is constructed in such a way, that\r
+> it is effective only once and when called by notmuch. The second call\r
+> to message-mode (from notmuch-message-mode) calls the original\r
+> message-mode.\r
+\r
+I wanted to answer this with an alternative patch, but I haven't had\r
+time.\r
+\r
+I admit to being somewhat prejudiced against shipping code with advice\r
+in it (IMHO it's fine for user specific customization, but not very\r
+maintainable).\r
+\r
+I think we might be better off in the long run replacing the call to\r
+message-mail. Code duplication is obviously not great, but perhaps some\r
+of the complexity of message-mail / message-pop-to-buffer can be\r
+eliminated, since we don't need to support all of the use cases of\r
+message-mail.\r
+\r
+> This implementation uses the new advice mechanism introduced in Emacs\r
+> 24.4. If we want to support older version, this must be changed.\r
+\r
+We do try to support Emacs 23 still (except for some optional\r
+features). Unfortunately old advice is even nastier.\r
+\r
+d\r
+\r