--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 375AA431FAF\r
+ for <notmuch@notmuchmail.org>; Wed, 29 May 2013 11:21:45 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 67pEb9kZtAJY for <notmuch@notmuchmail.org>;\r
+ Wed, 29 May 2013 11:21:34 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id A48F9431FAE\r
+ for <notmuch@notmuchmail.org>; Wed, 29 May 2013 11:21:34 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1Uhl01-00078L-EK; Wed, 29 May 2013 19:21:30 +0100\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1Uhl01-0002Kl-2I; Wed, 29 May 2013 19:21:25 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Subject: Re: v3 of --stderr=FILE patches\r
+In-Reply-To: <1369766335-26733-1-git-send-email-tomi.ollila@iki.fi>\r
+References: <1369766335-26733-1-git-send-email-tomi.ollila@iki.fi>\r
+User-Agent: Notmuch/0.14+255~gff3cc55 (http://notmuchmail.org) Emacs/23.4.1\r
+ (i486-pc-linux-gnu)\r
+Date: Wed, 29 May 2013 19:21:23 +0100\r
+Message-ID: <87r4gphckc.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: 00d4f7f818f2e6f492cbc3905e81a692 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -0.1\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored -0.1 points.\r
+ Summary of the scoring: \r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * -0.1 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+Cc: tomi.ollila@iki.fi\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 29 May 2013 18:21:45 -0000\r
+\r
+\r
+Just confirming LGTM +1 for this version too.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+\r
+> This is v3 of id:1369557954-13439-1-git-send-email-tomi.ollila@iki.fi\r
+>\r
+> In id:m2a9nfr4tb.fsf@guru.guru-group.fi I suggested to use 0600 as\r
+> permission bits so that files written to /tmp would not have write\r
+> bits set in any case. That would have been inconsistent what is\r
+> normally expected in redirection cases. The problem I described\r
+> is easily avoided in emacs as (make-temp-file "nmerr") will create\r
+> file "/tmp/nmerrXXXXXX" with permissions 0600 -- and writing to\r
+> that already-created file will not change its permissions. Writing\r
+> elsewhere is usually covered with directory permissions.\r
+>\r
+>\r
+> Diffdiff from v2 is shown below.\r
+>\r
+> diff --git a/NEWS b/NEWS\r
+> index 990b038..80abd97 100644\r
+> --- a/NEWS\r
+> +++ b/NEWS\r
+> @@ -38,8 +38,7 @@ Top level option to specify configuration file\r
+> Top level option to redirect writes to stderr\r
+> \r
+> With `notmuch --stderr=FILE` all writes to stderr are redirected to\r
+> - the specified file. If the file name is a plain '-', stderr is\r
+> - written to stdout.\r
+> + the specified file. If FILE is '-', stderr is redirected to stdout.\r
+> \r
+> Deprecated commands "part" and "search-tags" are removed.\r
+> \r
+> diff --git a/man/man1/notmuch.1 b/man/man1/notmuch.1\r
+> index fbd575a..f5ca0ad 100644\r
+> --- a/man/man1/notmuch.1\r
+> +++ b/man/man1/notmuch.1\r
+> @@ -83,7 +83,7 @@ configuration file specified by ${NOTMUCH_CONFIG}.\r
+> .B \-\-stderr=FILE\r
+> \r
+> Redirect all writes to stderr to the specified file.\r
+> -If the file name is a plain '-', stderr is written to stdout.\r
+> +If FILE is '-', stderr is redirected to stdout.\r
+> .RE\r
+> \r
+> .SH COMMANDS\r
+> diff --git a/notmuch.c b/notmuch.c\r
+> index 654a568..15e90c8 100644\r
+> --- a/notmuch.c\r
+> +++ b/notmuch.c\r
+> @@ -260,7 +260,7 @@ redirect_stderr (const char * stderr_file)\r
+> return 1;\r
+> }\r
+> } else {\r
+> - int fd = open (stderr_file, O_WRONLY|O_CREAT|O_APPEND, 0644);\r
+> + int fd = open (stderr_file, O_WRONLY|O_CREAT|O_TRUNC, 0666);\r
+> if (fd < 0) {\r
+> fprintf (stderr, "Error: Cannot redirect stderr to '%s': %s\n",\r
+> stderr_file, strerror (errno));\r
+>\r
+>\r
+> From Tomi Ollila <tomi.ollila@iki.fi> # This line is ignored.\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff