Re: [PATCH v2] contrib: pick: bugfix when trying to show a non-message

diff --git a/98/66569c9c0f78f1b14cf157cfba606d219bcc16 b/98/66569c9c0f78f1b14cf157cfba606d219bcc16
new file mode 100644 (file)
index 0000000..2062f07
--- /dev/null
+++ b/98/66569c9c0f78f1b14cf157cfba606d219bcc16
@@ -0,0 +1,99 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 39E9B431FB6\r
+       for <notmuch@notmuchmail.org>; Sat, 10 Nov 2012 08:23:45 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id YJWXgOTmVhzl for <notmuch@notmuchmail.org>;\r
+       Sat, 10 Nov 2012 08:23:44 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 99787431FAF\r
+       for <notmuch@notmuchmail.org>; Sat, 10 Nov 2012 08:23:44 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 64EA5100094;\r
+       Sat, 10 Nov 2012 18:23:43 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2] contrib: pick: bugfix when trying to show a\r
+ non-message\r
+In-Reply-To: <1352562350-8219-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1352562350-8219-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.14+84~g8a199bf (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sat, 10 Nov 2012 18:23:43 +0200\r
+Message-ID: <m2y5i94eb4.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 10 Nov 2012 16:23:45 -0000\r
+\r
+On Sat, Nov 10 2012, Mark Walters <markwalters1009@gmail.com> wrote:\r
+\r
+> If the user pressed return on the end result status line it gave a\r
+> blank message. Modify the function notmuch-pick-get-message-id to\r
+> return nil rather than an empty message-id in this case to fix this.\r
+>\r
+> This also fixes a bug in the (lack of) quoting of the id string.\r
+> ---\r
+\r
+LGTM\r
+\r
+Tomi\r
+\r
+> Version 1 is at\r
+> id:1351797983-19707-1-git-send-email-markwalters1009@gmail.com\r
+>\r
+> This version changes the `when' to and `if' and adds the fix for the\r
+> quoting.\r
+>\r
+> Best wishes\r
+>\r
+> Mark\r
+>\r
+>  contrib/notmuch-pick/notmuch-pick.el |    4 +++-\r
+>  1 files changed, 3 insertions(+), 1 deletions(-)\r
+>\r
+> diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el\r
+> index 15ac5e8..bbfa6fb 100644\r
+> --- a/contrib/notmuch-pick/notmuch-pick.el\r
+> +++ b/contrib/notmuch-pick/notmuch-pick.el\r
+> @@ -241,7 +241,9 @@ Some useful entries are:\r
+>  \r
+>  (defun notmuch-pick-get-message-id ()\r
+>    "Return the message id of the current message."\r
+> -  (concat "id:\"" (notmuch-pick-get-prop :id) "\""))\r
+> +  (let ((id (notmuch-pick-get-prop :id)))\r
+> +    (if id\r
+> +    (notmuch-id-to-query id))))\r
+>  \r
+>  (defun notmuch-pick-get-match ()\r
+>    "Return whether the current message is a match."\r
+> -- \r
+> 1.7.9.1\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r