Re: [PATCH] emacs: Correct the documentation for `notmuch-search-line-faces'.

diff --git a/78/c391fdf462b316a0c9e3283a434ecaba5bf046 b/78/c391fdf462b316a0c9e3283a434ecaba5bf046
new file mode 100644 (file)
index 0000000..6b93269
--- /dev/null
+++ b/78/c391fdf462b316a0c9e3283a434ecaba5bf046
@@ -0,0 +1,98 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 22080431FC2\r
+       for <notmuch@notmuchmail.org>; Tue,  6 May 2014 11:33:46 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id d+SGkkp7RdkG for <notmuch@notmuchmail.org>;\r
+       Tue,  6 May 2014 11:33:40 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 095CF431FAF\r
+       for <notmuch@notmuchmail.org>; Tue,  6 May 2014 11:33:40 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id A4C411000E5;\r
+       Tue,  6 May 2014 21:33:35 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: Correct the documentation\r
+       for     `notmuch-search-line-faces'.\r
+In-Reply-To: <1399370610-7146-1-git-send-email-dme@dme.org>\r
+References: <cun8uqffdo1.fsf@hotblack-desiato.hh.sledj.net>\r
+       <1399370610-7146-1-git-send-email-dme@dme.org>\r
+User-Agent: Notmuch/0.18+12~gbfbd199 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Tue, 06 May 2014 21:33:35 +0300\r
+Message-ID: <m2siomhi4g.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 06 May 2014 18:33:46 -0000\r
+\r
+On Tue, May 06 2014, David Edmondson <dme@dme.org> wrote:\r
+\r
+> The implementation and documentation for `notmuch-search-line-faces'\r
+> disagreed in how elements in the list were merged. Correct the\r
+> documentation to match the implementation (that is, the earlier\r
+> elements in the list have precedence over later elements).\r
+\r
+LGTM.\r
+\r
+Tomi\r
+\r
+\r
+\r
+> ---\r
+>  emacs/notmuch.el | 10 +++++-----\r
+>  1 file changed, 5 insertions(+), 5 deletions(-)\r
+>\r
+> diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+> index 6c0bc1b..8aa0104 100644\r
+> --- a/emacs/notmuch.el\r
+> +++ b/emacs/notmuch.el\r
+> @@ -647,12 +647,12 @@ of the result."\r
+>  Here is an example of how to color search results based on tags.\r
+>   (the following text would be placed in your ~/.emacs file):\r
+>  \r
+> - (setq notmuch-search-line-faces '((\"deleted\" . (:foreground \"red\"\r
+> -                                              :background \"blue\"))\r
+> -                                   (\"unread\" . (:foreground \"green\"))))\r
+> + (setq notmuch-search-line-faces '((\"unread\" . (:foreground \"green\"))\r
+> +                                   (\"deleted\" . (:foreground \"red\"\r
+> +                                              :background \"blue\"))))\r
+>  \r
+> -The attributes defined for matching tags are merged, with later\r
+> -attributes overriding earlier. A message having both \"deleted\"\r
+> +The attributes defined for matching tags are merged, with earlier\r
+> +attributes overriding later. A message having both \"deleted\"\r
+>  and \"unread\" tags with the above settings would have a green\r
+>  foreground and blue background."\r
+>    :type '(alist :key-type (string) :value-type (custom-face-edit))\r
+> -- \r
+> 2.0.0.rc0\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r