Re: [PATCH 1/3] cli: add insert --must-index option

diff --git a/3e/df31d00a11a0bbcf6b406cca89c8e6a271fb4b b/3e/df31d00a11a0bbcf6b406cca89c8e6a271fb4b
new file mode 100644 (file)
index 0000000..244d6a0
--- /dev/null
+++ b/3e/df31d00a11a0bbcf6b406cca89c8e6a271fb4b
@@ -0,0 +1,137 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 5512A431FC7\r
+       for <notmuch@notmuchmail.org>; Wed, 23 Oct 2013 12:05:40 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id K-squcbNu2j0 for <notmuch@notmuchmail.org>;\r
+       Wed, 23 Oct 2013 12:05:35 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 9918B431FBC\r
+       for <notmuch@notmuchmail.org>; Wed, 23 Oct 2013 12:05:35 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 534D4100217;\r
+       Wed, 23 Oct 2013 22:05:27 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>\r
+Subject: Re: [PATCH 1/3] cli: add insert --must-index option\r
+In-Reply-To: <87bo2xtdp2.fsf@unb.ca>\r
+References: <1374365254-13227-1-git-send-email-novalazy@gmail.com>\r
+       <87ip048gbj.fsf@qmul.ac.uk>\r
+       <20130727151510.GA13750@hili.localdomain>\r
+       <87hadtxfrr.fsf@qmul.ac.uk>\r
+       <20130912001349.GA18821@hili.localdomain>\r
+       <87zjqhv264.fsf@zancas.localnet>\r
+       <m238o9fguj.fsf@guru.guru-group.fi> <87bo2xtdp2.fsf@unb.ca>\r
+User-Agent: Notmuch/0.16+115~g11c2ff5 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 23 Oct 2013 22:05:26 +0300\r
+Message-ID: <m2eh7bu7t5.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: quoted-printable\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 23 Oct 2013 19:05:40 -0000\r
+\r
+On Thu, Oct 10 2013, David Bremner <david@tethera.net> wrote:\r
+\r
+> Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+>>> I'm not opposed to doing an SONAME bump for 0.17. Are there other ABI\r
+>>> breaking changes that we have been holding back on? Can these maybe go\r
+>>> through at the same time?\r
+>>\r
+>> Maybe something along these lines...\r
+>>\r
+>> (Quick draft for the API part; to start discussion before working too mu=\r
+ch\r
+>> for something that is going to be dropped...)\r
+>>\r
+>>  notmuch_status_t\r
+>> -notmuch_database_create (const char *path, notmuch_database_t **databas=\r
+e);\r
+>> +notmuch_database_create (const char *path,\r
+>> +                    notmuch_loghook_t *loghook,\r
+>> +                    notmuch_database_t **database);\r
+>\r
+> Another idea floated (by Austin?) was to pass in an options struct, to\r
+> allow future options to be added without changing the function\r
+> signature. I guess with some care this could be done in an upwardly\r
+> compatible way.\r
+\r
+Maybe something like\r
+\r
+#define NOTMUCH_API_OPTIONS_VERSION 1\r
+typedef struct {\r
+        int options_version;\r
+        void (*log)(void *, int level, int status, const char * format, ...=\r
+);\r
+        void * logdata;\r
+} notmuch_options_t;=20=20=20=20=20=20=20=20\r
+\r
+...\r
+\r
+notmuch_status_t\r
+notmuch_database_create (const char *path,\r
+                        notmuch_options_t *options,\r
+                        notmuch_database_t **database);\r
+...\r
+\r
+notmuch_status_t\r
+notmuch_database_open (const char *path,\r
+                       notmuch_database_mode_t mode,\r
+                       notmuch_options_t *options,\r
+                       notmuch_database_t **database);\r
+\r
+then in use:\r
+\r
+notmuch_options_t options =3D {\r
+       .options_version =3D NOTMUCH_API_OPTIONS_VERSION,\r
+\r
+.. =C3=A4sh, this has problem that the macro changes in header file\r
+but the structure initialization is not following automatically\r
+(in other fields than that). Therefore perhaps "fixing"\r
+the version macros:\r
+\r
+#define NOTMUCH_API_OPTIONS_VERSION_1 1\r
+/* #define NOTMUCH_API_OPTIONS_VERSION_2 2 // added in the future */\r
+\r
+notmuch_options_t options =3D {\r
+       .options_version =3D NOTMUCH_API_OPTIONS_VERSION_1,\r
+       .log =3D log_to_stderr,\r
+       .logdata =3D NULL\r
+};\r
+\r
+Well, this is one idea (does not sound as good as I initially\r
+thought...) how does other software tackle this kind of issues...\r
+\r
+If something like this is finally chosen we could provide easy\r
+transition path to allow NULL as options -- making notmuch CLI\r
+behave as it used to be (log to stderr...).\r
+\r
+\r
+> d\r
+\r
+Tomi\r