--- /dev/null
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id C6A29431FC4\r
+ for <notmuch@notmuchmail.org>; Wed, 13 Nov 2013 13:58:55 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.023\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.023 tagged_above=-999 required=5\r
+ tests=[HS_INDEX_PARAM=0.023] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id ndsECL78fGTJ for <notmuch@notmuchmail.org>;\r
+ Wed, 13 Nov 2013 13:58:47 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by olra.theworths.org (Postfix) with ESMTP id 7AEA5429E25\r
+ for <notmuch@notmuchmail.org>; Wed, 13 Nov 2013 13:58:46 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id A4040100033;\r
+ Wed, 13 Nov 2013 23:58:41 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: show: stop stderr appearing in buffer\r
+In-Reply-To: <1384333417-13832-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1384333417-13832-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.16+119~g219c55f (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 13 Nov 2013 23:58:41 +0200\r
+Message-ID: <m2bo1oyne6.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 13 Nov 2013 21:58:56 -0000\r
+\r
+On Wed, Nov 13 2013, Mark Walters <markwalters1009@gmail.com> wrote:\r
+\r
+> In emacs 24.3+ the stdout/stderr from externally displaying an\r
+> attachment gets inserted into the show buffer. This is caused by\r
+> changes in mm-display-external in mm-decode.el.\r
+>\r
+> Ideally, we would put this output in the notmuch errors buffer but the\r
+> handler is called asynchronously so we don't know when the output will\r
+> appear. Thus if we put it straight into the errors buffer it could get\r
+> interleaved with other errors. Also we can't easily tell when we\r
+> have got all the error output so can't wait until the process is complete.\r
+>\r
+> One solution would be to create a new buffer for the stderr of each\r
+> attachment viewed. Again, since we can't tell when the process has\r
+> finished, we can't close these buffers automatically so this will\r
+> leave lots of buffers around.\r
+>\r
+> Thus we add a debug variable notmuch-show-attachment-debug: it this is\r
+> non-nil we create a new buffer for each viewer; if this variable is\r
+> nil we just use a temp buffer which means all error output is\r
+> discarded (this is the same behaviour as with emacs pre 24.3).\r
+> ---\r
+\r
+This patch looks tolerable to me. +1\r
+\r
+Tomi\r
+\r
+>\r
+> This is a new version of\r
+> id:1378502198-7980-1-git-send-email-markwalters1009@gmail.com I don't\r
+> think there was complete consensus on the right thing to do here but\r
+> most people wanted at least the option of seeing the stderr/stdout.\r
+>\r
+> This keeps the default behaviour the same as before, but adds a debug\r
+> variable to put the stderr/stdout in its own buffer.\r
+>\r
+> Note: I always use emacs 23 so this is not heavily tested.\r
+>\r
+> Best wishes\r
+>\r
+> Mark\r
+>\r
+>\r
+> emacs/notmuch-show.el | 12 +++++++++++-\r
+> 1 files changed, 11 insertions(+), 1 deletions(-)\r
+>\r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index f00273a..f9a3344 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -159,6 +159,8 @@ indentation."\r
+> (make-variable-buffer-local 'notmuch-show-indent-content)\r
+> (put 'notmuch-show-indent-content 'permanent-local t)\r
+> \r
+> +(defvar notmuch-show-attachment-debug nil)\r
+> +\r
+> (defcustom notmuch-show-stash-mlarchive-link-alist\r
+> '(("Gmane" . "http://mid.gmane.org/")\r
+> ("MARC" . "http://marc.info/?i=")\r
+> @@ -2089,8 +2091,16 @@ caller is responsible for killing this buffer as appropriate."\r
+> This ensures that the temporary buffer created for the mm-handle\r
+> is destroyed when FN returns."\r
+> (let ((handle (notmuch-show-current-part-handle)))\r
+> + ;; emacs 24.3+ puts stdout/stderr into the calling buffer so we\r
+> + ;; call it from a temp-buffer, unless\r
+> + ;; notmuch-show-attachment-debug is non-nil in which case we put\r
+> + ;; it in " *notmuch-part*".\r
+> (unwind-protect\r
+> - (funcall fn handle)\r
+> + (if notmuch-show-attachment-debug\r
+> + (with-current-buffer (generate-new-buffer " *notmuch-part*")\r
+> + (funcall fn handle))\r
+> + (with-temp-buffer\r
+> + (funcall fn handle)))\r
+> (kill-buffer (mm-handle-buffer handle)))))\r
+> \r
+> (defun notmuch-show-part-button-default (&optional button)\r
+> -- \r
+> 1.7.9.1\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff