Re: [PATCH 3/5] Fix hiding a message while some citations are shown in notmuch-show...

diff --git a/10/826587feb162667bf232e81cff6b511d281152 b/10/826587feb162667bf232e81cff6b511d281152
new file mode 100644 (file)
index 0000000..abea4fa
--- /dev/null
+++ b/10/826587feb162667bf232e81cff6b511d281152
@@ -0,0 +1,102 @@
+Return-Path: <cworth@cworth.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id C03EC429E5A\r
+       for <notmuch@notmuchmail.org>; Wed, 25 May 2011 18:03:03 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.01\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.01 tagged_above=-999 required=5\r
+       tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 99pI2okTC6Nl for <notmuch@notmuchmail.org>;\r
+       Wed, 25 May 2011 18:03:03 -0700 (PDT)\r
+Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2])\r
+       by olra.theworths.org (Postfix) with ESMTP id 2AA06429E54\r
+       for <notmuch@notmuchmail.org>; Wed, 25 May 2011 18:02:57 -0700 (PDT)\r
+Received: from yoom.home.cworth.org (localhost [127.0.0.1])\r
+       by arlo.cworth.org (Postfix) with ESMTP id 2CDE229A4FA;\r
+       Wed, 25 May 2011 18:02:56 -0700 (PDT)\r
+Received: by yoom.home.cworth.org (Postfix, from userid 1000)\r
+       id 1EB7525417E; Wed, 25 May 2011 18:02:56 -0700 (PDT)\r
+From: Carl Worth <cworth@cworth.org>\r
+To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 3/5] Fix hiding a message while some citations are shown\r
+       in notmuch-show view.\r
+In-Reply-To: <87hb8ipeb0.fsf@gmail.com>\r
+References: <1306361416-5019-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <1306361416-5019-4-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <87oc2qa07g.fsf@yoom.home.cworth.org> <87k4depfyj.fsf@gmail.com>\r
+       <87lixu9z5b.fsf@yoom.home.cworth.org> <87hb8ipeb0.fsf@gmail.com>\r
+User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1\r
+       (i486-pc-linux-gnu)\r
+Date: Wed, 25 May 2011 18:02:49 -0700\r
+Message-ID: <87ipsy9sue.fsf@yoom.home.cworth.org>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 26 May 2011 01:03:04 -0000\r
+\r
+--=-=-=\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Thu, 26 May 2011 03:10:11 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmai=\r
+l.com> wrote:\r
+> On Wed, 25 May 2011 15:46:40 -0700, Carl Worth <cworth@cworth.org> wrote:\r
+> Well, emacs trunk is not broken :)  The bug is in lisp code, so you can\r
+> fix it in .emacs by redefining `isearch-range-invisible' function.  I do\r
+> that now.\r
+\r
+Oh, in that case we can fix this is notmuch emacs lisp by just defining\r
+and using a fixed function. Is the broken function something we're\r
+calling directly? Or is it being called indirectly? (being called by\r
+other emacs lisp code that we are calling)?\r
+\r
+If we can incorporate the fix, that would be great.\r
+\r
+> Please consider pushing other patches from the series.  They do not fix\r
+> any bug, but do simplify the code.  The last patch uses list for\r
+> invisible overlay property as well.  But it does not break isearch\r
+> because we do not search in hidden messages.\r
+\r
+Hmmm... we should probably do that. I'd like isearch in notmuch to\r
+search anything that is hidden.\r
+\r
+> BTW would be nice to have a set of known-to-fail tests, i.e. bugs that\r
+> are not fixed yet.  If we had it, the above test could be implemented\r
+> and committed before we have the fix pushed.\r
+\r
+We do! Use test_expect_equal_failure (yes, the name is horrible!)\r
+instead of test_expect_equal and you should get what you want.\r
+\r
+=2DCarl\r
+\r
+=2D-=20\r
+carl.d.worth@intel.com\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iEYEARECAAYFAk3dprkACgkQ6JDdNq8qSWjOZACcChjCFqJrnrrBTSOMoaw4Cxy4\r
+lusAniCy0nJl47gVy+QUvbrMZm0Ijouy\r
+=R0BE\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r