Re: Bug#755544: notmuch-emacs: doesn't check gpg/pgp signatures by default

diff --git a/9b/e7a720b0df44d862b72ce92a5adb43a46d1b9a b/9b/e7a720b0df44d862b72ce92a5adb43a46d1b9a
new file mode 100644 (file)
index 0000000..a5c11dd
--- /dev/null
+++ b/9b/e7a720b0df44d862b72ce92a5adb43a46d1b9a
@@ -0,0 +1,128 @@
+Return-Path: <dme@dme.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id D43206DE0AC2\r
+ for <notmuch@notmuchmail.org>; Mon,  8 Feb 2016 09:46:48 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.008\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.008 tagged_above=-999 required=5 tests=[AWL=0.059,\r
+  DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\r
+ RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_NEUTRAL=0.652,\r
+ UNPARSEABLE_RELAY=0.001] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id VQv3DGdiMq9i for <notmuch@notmuchmail.org>;\r
+ Mon,  8 Feb 2016 09:46:47 -0800 (PST)\r
+Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com\r
+ [74.125.82.51]) by arlo.cworth.org (Postfix) with ESMTPS id 9E09E6DE02CE for\r
+ <notmuch@notmuchmail.org>; Mon,  8 Feb 2016 09:46:46 -0800 (PST)\r
+Received: by mail-wm0-f51.google.com with SMTP id p63so126462918wmp.1\r
+ for <notmuch@notmuchmail.org>; Mon, 08 Feb 2016 09:46:46 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+ d=dme-org.20150623.gappssmtp.com; s=20150623;\r
+ h=to:cc:subject:in-reply-to:references:from:date:message-id\r
+ :mime-version:content-type;\r
+ bh=cpSssJUkKwE4wK0xkhRQYSJlKv1yc9eiCZg0nIczNVE=;\r
+ b=jTOD/qpnQ4gzfsHrp7q8yJ+11gi2KZJ5AoDkE6sfUMfxGIRx6eTEQByVP2kLsqrEUR\r
+ rXR4fc9YUD+Z8UoAJg3We3MuzkSIoY+7mRXanV7yVzl/wdfWntogAZ1vWgyeq3xDUs1I\r
+ CaeC0pKW2jKpMed6Art43vKzVHJXtDc3QGSiIW0yJyYMHUICb1tgs48/74d/2OyxuFWM\r
+ 8GejC6KhMF6FTtxSHDhQjuDnjPHEIXA4Uzm6oY2boKOvzWCdxDxVSysZZOjooJqkdCLn\r
+ TDzJg6go/NbSEC801ZSUrSG8Ax34Xh6wbsAhn21nSIxA9Rx7dgm/kbvCQmFhyDhi/aIg\r
+ PO8Q==\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+ d=1e100.net; s=20130820;\r
+ h=x-gm-message-state:to:cc:subject:in-reply-to:references:from:date\r
+ :message-id:mime-version:content-type;\r
+ bh=cpSssJUkKwE4wK0xkhRQYSJlKv1yc9eiCZg0nIczNVE=;\r
+ b=cMyMAT0Ie/0GJo0u3kBBIhoD4WV/n9dItDw0APxNSiK/MqIILcyN6nHnXQDCwxPhrW\r
+ p4kLQEL16d4uusjrAJs7QoUXw0ussJZUvyfrr0ThXj+i5BIEn8E50gDQYKlJQ/zsCo9t\r
+ 0wMAqUohKNEQQafC7s8dD78thXaLMLll7Ga3UHvv6faswQ1agiuy2XEv5nHuU++vOu+9\r
+ mPH/a+qMP9bMyIn8mOFTh0NRzEaiN7a5Wf8kQLn0y/hShSFZGoCk/Ue7GdND/qlvrBjw\r
+ 2n+MqxOMLbnpduWpGuVgt6NFYIHjVIqfbmMA3jGoVHCPpf6hLfAAE4scSpmysttvVc13\r
+ /U0g==\r
+X-Gm-Message-State:\r
+ AG10YOR83vZCL8T/8USFnat+1oq+dMfD2nzOeHbcP30IbHucqdq1Dsa1xRhY/GfAozzOOA==\r
+X-Received: by 10.28.214.76 with SMTP id n73mr93379wmg.52.1454953605162;\r
+ Mon, 08 Feb 2016 09:46:45 -0800 (PST)\r
+Received: from disaster-area.hh.sledj.net\r
+ ([2a01:348:1a2:1:ea39:35ff:fe2c:a227])\r
+ by smtp.gmail.com with ESMTPSA id m63sm13722271wmc.3.2016.02.08.09.46.43\r
+ (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
+ Mon, 08 Feb 2016 09:46:44 -0800 (PST)\r
+Received: from localhost (disaster-area.hh.sledj.net [local])\r
+ by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id 70883960;\r
+ Mon, 8 Feb 2016 17:46:43 +0000 (UTC)\r
+To: David Bremner <david@tethera.net>,\r
+ Jameson Graef Rollins <jrollins@finestructure.net>,\r
+ Vagrant Cascadian <vagrant@debian.org>, 755544@bugs.debian.org\r
+Cc: notmuch@notmuchmail.org\r
+Subject: Re: Bug#755544: notmuch-emacs: doesn't check gpg/pgp signatures\r
+ by    default\r
+In-Reply-To: <878unlenhn.fsf@maritornes.cs.unb.ca>\r
+References: <20140721223426.GA5250@siren>\r
+ <87silucnfx.fsf@maritornes.cs.unb.ca>\r
+ <87iomqxkzp.fsf@servo.finestructure.net>\r
+ <878unlenhn.fsf@maritornes.cs.unb.ca>\r
+From: David Edmondson <dme@dme.org>\r
+Date: Mon, 08 Feb 2016 17:46:42 +0000\r
+Message-ID: <m2oabr3xj1.fsf@heart-of-gold.hh.sledj.net>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 08 Feb 2016 17:46:49 -0000\r
+\r
+On Tue, Jul 22 2014, David Bremner wrote:\r
+> Jameson Graef Rollins <jrollins@finestructure.net> writes:\r
+>\r
+>> On Mon, Jul 21 2014, David Bremner <david@tethera.net> wrote:\r
+>>> notmuch folks: it seems that in vagrant's message, and several others I\r
+>>> checked, it notmuch-crypto-process-mime==nil, then no signature button\r
+>>> is created at all.\r
+>>\r
+>> Yes, this is true.  The signature button is pretty meaningless if we're\r
+>> not processing the signature.\r
+>>\r
+>> Maybe instead by default we could have a signature button that opens up\r
+>> a notmuch-crypto-process-mime customization buffer?\r
+>>\r
+>> jamie.\r
+>\r
+> looking at the source, there is supposed to be some button:\r
+\r
+There is a button for the part (the one that says "[multipart/signed]")\r
+and the help text is associated with that. There is no button\r
+specifically for the signature (because no processing of the signature\r
+took place).\r
+\r
+It wouldn't be complicated to add a button in the case where no checking\r
+was done. Pressing the button could (as suggested) offer up\r
+customisation of the variable (or just open the help).\r
+\r
+I wonder if I could make the button be "[Danger Will Robinson!!!]" in\r
+flashing red and yellow text...\r
+\r
+> ,----\r
+> | (defun notmuch-show-insert-part-multipart/signed (msg part content-type nth depth button)\r
+> |   (button-put button 'face 'notmuch-crypto-part-header)\r
+> |   ;; add signature status button if sigstatus provided\r
+> |   (if (plist-member part :sigstatus)\r
+> |       (let* ((from (notmuch-show-get-header :From msg))\r
+> |         (sigstatus (car (plist-get part :sigstatus))))\r
+> |    (notmuch-crypto-insert-sigstatus-button sigstatus from))\r
+> |     ;; if we're not adding sigstatus, tell the user how they can get it\r
+> |     (button-put button 'help-echo "Set notmuch-crypto-process-mime to process cryptographic MIME parts."))\r
+> `----\r