Re: [PATCH v3 02/16] Move crypto.c into libutil

diff --git a/47/cc580f86ef6936aa6929154325fbffa51d089a b/47/cc580f86ef6936aa6929154325fbffa51d089a
new file mode 100644 (file)
index 0000000..4d7c8f7
--- /dev/null
+++ b/47/cc580f86ef6936aa6929154325fbffa51d089a
@@ -0,0 +1,101 @@
+Return-Path: <dkg@fifthhorseman.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 37D0E6DE0BF6\r
+ for <notmuch@notmuchmail.org>; Wed, 10 Feb 2016 06:34:29 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.019\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.019 tagged_above=-999 required=5\r
+ tests=[AWL=-0.019] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 3xY04vBiQpRb for <notmuch@notmuchmail.org>;\r
+ Wed, 10 Feb 2016 06:34:27 -0800 (PST)\r
+Received: from che.mayfirst.org (che.mayfirst.org [209.234.253.108])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 507C66DE0B36\r
+ for <notmuch@notmuchmail.org>; Wed, 10 Feb 2016 06:34:27 -0800 (PST)\r
+Received: from fifthhorseman.net (unknown [38.109.115.130])\r
+ by che.mayfirst.org (Postfix) with ESMTPSA id AB729F997;\r
+ Wed, 10 Feb 2016 09:34:21 -0500 (EST)\r
+Received: by fifthhorseman.net (Postfix, from userid 1000)\r
+ id DCF382017F; Wed, 10 Feb 2016 09:34:22 -0500 (EST)\r
+From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>\r
+To: David Bremner <david@tethera.net>, Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH v3 02/16] Move crypto.c into libutil\r
+In-Reply-To: <87wpqduwz6.fsf@maritornes.cs.unb.ca>\r
+References: <1454272801-23623-1-git-send-email-dkg@fifthhorseman.net>\r
+ <1454272801-23623-3-git-send-email-dkg@fifthhorseman.net>\r
+ <87wpqduwz6.fsf@maritornes.cs.unb.ca>\r
+User-Agent: Notmuch/0.21+72~gd8c4f1c (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Wed, 10 Feb 2016 09:34:22 -0500\r
+Message-ID: <87io1wocr5.fsf@alice.fifthhorseman.net>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 10 Feb 2016 14:34:29 -0000\r
+\r
+On Tue 2016-02-09 21:21:01 -0500, David Bremner wrote:\r
+> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:\r
+>\r
+>> This prepares us for using the crypto object in both the library and\r
+>> the client.\r
+>>\r
+>> i've prefixed notmuch_crypto with _ to indicate that while this can be\r
+>> built into the library when needed, it's not something to be exported\r
+>> or used externally.\r
+>\r
+> [...] snip\r
+>\r
+>> diff --git a/mime-node.c b/mime-node.c\r
+>> index e96e663..a8f5670 100644\r
+>> --- a/mime-node.c\r
+>> +++ b/mime-node.c\r
+>> @@ -33,7 +33,7 @@ typedef struct mime_node_context {\r
+>>      GMimeMessage *mime_message;\r
+>>  \r
+>>      /* Context provided by the caller. */\r
+>> -    notmuch_crypto_t *crypto;\r
+>> +    _notmuch_crypto_t *crypto;\r
+>>  } mime_node_context_t;\r
+>\r
+> is this maybe search and replace gone wild? or did you mean\r
+> to rename the type as well as the functions?\r
+\r
+this is a type in the util library (which is shared between libnotmuch\r
+and the cli, but not exposed by libnotmuch).  As such, i deliberately\r
+renamed the type to appear more explicitly "private".  I do not think we\r
+want to expose it to the library API, in part because it "contaminates"\r
+libnotmuch with the gmime API (because it explicitly contemplates the\r
+use of GMimeCryptoContext, see below).\r
+\r
+>>  static void\r
+>>  node_verify (mime_node_t *node, GMimeObject *part,\r
+>> -        notmuch_crypto_context_t *cryptoctx)\r
+>> +        GMimeCryptoContext *cryptoctx)\r
+>>  {\r
+>\r
+> This change of parameter type seems significant. Does it deserve a\r
+> comment in the commit message?\r
+\r
+I don't think this is a big change.  notmuch_crypto_context was\r
+originally a typedef to GMimeCryptoContext, and it wasn't being exposed\r
+by the library API.  Rather than pretend that it's something distinct, i\r
+think it makes more explicit that this internal part of util deals with\r
+libgmime.\r
+\r
+        --dkg\r