Re: [PATCH] Add a defcustom for whether to block remote images by default.

diff --git a/6c/e245ec336dc2b9dbdfb22e09e4d6675acdb7ff b/6c/e245ec336dc2b9dbdfb22e09e4d6675acdb7ff
new file mode 100644 (file)
index 0000000..d3a4f58
--- /dev/null
+++ b/6c/e245ec336dc2b9dbdfb22e09e4d6675acdb7ff
@@ -0,0 +1,128 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 36F7C431FC4\r
+       for <notmuch@notmuchmail.org>; Thu, 29 Jan 2015 12:25:45 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 2.438\r
+X-Spam-Level: **\r
+X-Spam-Status: No, score=2.438 tagged_above=-999 required=5\r
+       tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id TZSjMe2VnFir for <notmuch@notmuchmail.org>;\r
+       Thu, 29 Jan 2015 12:25:42 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id D15C0431FBC\r
+       for <notmuch@notmuchmail.org>; Thu, 29 Jan 2015 12:25:41 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 2A1B1100033;\r
+       Thu, 29 Jan 2015 22:25:16 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Jinwoo Lee <jinwoo68@gmail.com>, David Bremner <david@tethera.net>,\r
+       notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] Add a defcustom for whether to block remote images by\r
+       default.\r
+In-Reply-To: <yq65mw51h4td.fsf@jinwoo-macbookair.roam.corp.google.com>\r
+References: <1422495572-40384-1-git-send-email-jinwoo68@gmail.com>\r
+       <87pp9yjbhw.fsf@maritornes.cs.unb.ca>\r
+       <m2sieut13t.fsf@guru.guru-group.fi>\r
+       <yq65mw51h4td.fsf@jinwoo-macbookair.roam.corp.google.com>\r
+User-Agent: Notmuch/0.19+53~gb45d2f9 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Thu, 29 Jan 2015 22:25:15 +0200\r
+Message-ID: <m2bnlh8hck.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 29 Jan 2015 20:25:45 -0000\r
+\r
+On Thu, Jan 29 2015, Jinwoo Lee <jinwoo68@gmail.com> wrote:\r
+\r
+> On Thu, Jan 29, 2015 at 12:58 AM, Tomi Ollila <tomi.ollila@iki.fi> wrote:\r
+>> On Thu, Jan 29 2015, David Bremner <david@tethera.net> wrote:\r
+>>\r
+>>> Jinwoo Lee <jinwoo68@gmail.com> writes:\r
+>>>\r
+>>>> + (shr-blocked-images (if notmuch-show-block-remote-images\r
+>>>> +                         "."\r
+>>>> +                       shr-blocked-images)))\r
+>>>>      (shr-insert-document dom)\r
+>>>>      t))\r
+>>>\r
+>>> Ideally such a customization would apply to all html renders. I think\r
+>>> Tomi did some experiments with w3m and friends, I _think_ they respect\r
+>>> gnus-blocked-images, but maybe Tomi can comment.\r
+>>\r
+>> I did M-x debug-on-entry RET open-network-stream RET  (or an equivalent of\r
+>> t that in elisp, but the code I did is now lost & forgotten ;/\r
+>>\r
+>> The docstring relevant to the renderers below it at the end of this email.\r
+>>\r
+>> 'gnus-w3m respect gnus-blocked-images\r
+>>\r
+>> I could not run 'w3m on that system... nor 'w3\r
+>>\r
+>> There was no effect with 'w3m-standalone -- in this case I'd think it is up\r
+>> to w3m binary to load external stuff or not. I presume the same is the\r
+>> case with 'links, 'lynx, 'html2text and nil\r
+>>\r
+>> So, to add to David's suggestion maybe just set both gnus-blocked-images\r
+>> and shr-blocked-images to the value of\r
+>> notmuch-show-text/html-blocked-images\r
+>\r
+> All right.  I sent another patch that does this.  Thanks, guys!\r
+\r
+Thanks for your contribution. You seem to have taken my suggestion\r
+literally just that it IIRC now only sets those when using shr renderer --\r
+setting of gnus-blocked images should be in other code path... i am not\r
+sure though i am sending this using mobile phi0one terminal and checking\r
+for sure is just too PITA ;\\r
+\r
+Tomi\r
+\r
+>\r
+>>\r
+>>\r
+>> Tomi\r
+>>\r
+>>\r
+>> mm-text-html-renderer is a variable defined in `mm-decode.el'.\r
+>> Its value is shr\r
+>>\r
+>> Documentation:\r
+>> Render of HTML contents.\r
+>> It is one of defined renderer types, or a rendering function.\r
+>> The defined renderer types are:\r
+>> `shr': use the built-in Gnus HTML renderer;\r
+>> `gnus-w3m': use Gnus renderer based on w3m;\r
+>> `w3m': use emacs-w3m;\r
+>> `w3m-standalone': use plain w3m;\r
+>> `links': use links;\r
+>> `lynx': use lynx;\r
+>> `w3': use Emacs/W3;\r
+>> `html2text': use html2text;\r
+>> nil    : use external viewer (default web browser).\r
+>>\r
+>>\r
+>>> d\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r