Re: [PATCH v2 4/6] cli: config: make notmuch_config_open() "is new" parameter input...

diff --git a/c7/a3a47e710a870cd3ad1c85d3a0cf1c27794bb6 b/c7/a3a47e710a870cd3ad1c85d3a0cf1c27794bb6
new file mode 100644 (file)
index 0000000..b78e4ea
--- /dev/null
+++ b/c7/a3a47e710a870cd3ad1c85d3a0cf1c27794bb6
@@ -0,0 +1,71 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id DD0B6431FAF\r
+       for <notmuch@notmuchmail.org>; Thu,  7 Mar 2013 05:44:55 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id KoUCDMYmb6Z3 for <notmuch@notmuchmail.org>;\r
+       Thu,  7 Mar 2013 05:44:55 -0800 (PST)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 622D1431FAE\r
+       for <notmuch@notmuchmail.org>; Thu,  7 Mar 2013 05:44:55 -0800 (PST)\r
+Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([156.34.82.78] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1UDb7r-0006Th-84; Thu, 07 Mar 2013 09:44:51 -0400\r
+Received: from bremner by zancas.localnet with local (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1UDb7l-0007VF-FM; Thu, 07 Mar 2013 09:44:45 -0400\r
+From: David Bremner <david@tethera.net>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 4/6] cli: config: make notmuch_config_open() "is new"\r
+       parameter input only\r
+In-Reply-To:\r
+ <5faebfc5d36d7e85a4dd1acbca0417d8a6a2602d.1362347362.git.jani@nikula.org>\r
+References: <cover.1362347362.git.jani@nikula.org>\r
+       <5faebfc5d36d7e85a4dd1acbca0417d8a6a2602d.1362347362.git.jani@nikula.org>\r
+User-Agent: Notmuch/0.15.2+32~g16aa65b (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Thu, 07 Mar 2013 09:44:45 -0400\r
+Message-ID: <87boavxr1u.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 07 Mar 2013 13:44:56 -0000\r
+\r
+Jani Nikula <jani@nikula.org> writes:\r
+\r
+> We now have a notmuch_config_is_new() function to query whether a\r
+> config was created or not. Change the notmuch_config_open() is_new\r
+> parameter into boolean create_new to determine whether the function\r
+> should create a new config if one doesn't exist. This reduces the\r
+> complexity of the API.\r
+\r
+I have pushed the first 4 patches in this series. I'd like a second\r
+(third?) pair of eyes on 5/6.\r
+\r
+d\r