Re: [PATCH 1/2] test: Search for non-existent message should return nothing
authorCarl Worth <cworth@cworth.org>
Thu, 4 Nov 2010 19:39:01 +0000 (12:39 +1700)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:37:22 +0000 (09:37 -0800)
45/e626a33388631f5cd773befa2eec821178561b [new file with mode: 0644]

diff --git a/45/e626a33388631f5cd773befa2eec821178561b b/45/e626a33388631f5cd773befa2eec821178561b
new file mode 100644 (file)
index 0000000..f9e428b
--- /dev/null
@@ -0,0 +1,86 @@
+Return-Path: <cworth@cworth.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 7A4F340D168\r
+       for <notmuch@notmuchmail.org>; Thu,  4 Nov 2010 12:39:14 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.89\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.89 tagged_above=-999 required=5\r
+       tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, T_MIME_NO_TEXT=0.01]\r
+       autolearn=ham\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 6a6UK9HeDd-1; Thu,  4 Nov 2010 12:39:02 -0700 (PDT)\r
+Received: from yoom.home.cworth.org (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 7BC1740D158;\r
+       Thu,  4 Nov 2010 12:39:02 -0700 (PDT)\r
+Received: by yoom.home.cworth.org (Postfix, from userid 1000)\r
+       id CE982254102; Thu,  4 Nov 2010 12:39:01 -0700 (PDT)\r
+From: Carl Worth <cworth@cworth.org>\r
+To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/2] test: Search for non-existent message should return\r
+       nothing\r
+In-Reply-To: <1288628140-15410-1-git-send-email-sojkam1@fel.cvut.cz>\r
+References: <1288628140-15410-1-git-send-email-sojkam1@fel.cvut.cz>\r
+User-Agent: Notmuch/0.4 (http://notmuchmail.org) Emacs/23.2.1\r
+       (i486-pc-linux-gnu)\r
+Date: Thu, 04 Nov 2010 12:39:01 -0700\r
+Message-ID: <87vd4cq3oq.fsf@yoom.home.cworth.org>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 04 Nov 2010 19:39:14 -0000\r
+\r
+--=-=-=\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Mon,  1 Nov 2010 17:15:39 +0100, Michal Sojka <sojkam1@fel.cvut.cz> wrot=\r
+e:\r
+> My scripts expect that empty search result is actually empty. Since\r
+> commit 6dcb7592, even empty search prints a newline character and this\r
+> breaks my scripts.\r
+\r
+Thanks for this fix, Michal.\r
+\r
+I get to apologize doubly on this one.\r
+\r
+First, I'm sorry that I was greedy and tried to factor out some common\r
+code, not realizing the bug I introduced in the process.\r
+\r
+Second, I'm sorry I didn't get your fix into the 0.4 release, (since I\r
+think you did send it before I wrapped that up).\r
+\r
+I've at least pushed your fix now. Thanks especially for including a new\r
+test (and fix!) with your bug report. That's hugely appreciated.\r
+\r
+=2DCarl\r
+\r
+=2D-=20\r
+carl.d.worth@intel.com\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.10 (GNU/Linux)\r
+\r
+iD8DBQFM0wvV6JDdNq8qSWgRAiVoAJ9IGAMRk388VZ0uPfVwLOGodpq21ACfb8mG\r
+1DkcU3HKeigbAFgGHfstzkQ=\r
+=bivo\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r