Re: [PATCH 2/2] contrib: pick: thread tagging (including archiving) implemented

diff --git a/bc/f28c979b17142c7bd1106e151ebf90194cfa13 b/bc/f28c979b17142c7bd1106e151ebf90194cfa13
new file mode 100644 (file)
index 0000000..2f40cd8
--- /dev/null
+++ b/bc/f28c979b17142c7bd1106e151ebf90194cfa13
@@ -0,0 +1,88 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 150BC429E59\r
+       for <notmuch@notmuchmail.org>; Sat,  1 Jun 2013 12:48:31 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id UZiVTC0QxCoi for <notmuch@notmuchmail.org>;\r
+       Sat,  1 Jun 2013 12:48:23 -0700 (PDT)\r
+Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 7DB2F431FDE\r
+       for <notmuch@notmuchmail.org>; Sat,  1 Jun 2013 12:48:23 -0700 (PDT)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id r51JmJ8V020719;\r
+       Sat, 1 Jun 2013 16:48:19 -0300\r
+Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([156.34.82.78] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1Uirml-00077Q-GK; Sat, 01 Jun 2013 16:48:19 -0300\r
+Received: from bremner by zancas.localnet with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1Uirmf-0001Xr-QG; Sat, 01 Jun 2013 16:48:13 -0300\r
+From: David Bremner <david@tethera.net>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 2/2] contrib: pick: thread tagging (including archiving)\r
+       implemented\r
+In-Reply-To: <1354970914-18342-3-git-send-email-markwalters1009@gmail.com>\r
+References: <1354970914-18342-1-git-send-email-markwalters1009@gmail.com>\r
+       <1354970914-18342-3-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.15.2+114~g3b2344e (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 01 Jun 2013 16:48:13 -0300\r
+Message-ID: <87zjv91uki.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 01 Jun 2013 19:48:31 -0000\r
+\r
+Mark Walters <markwalters1009@gmail.com> writes:\r
+\r
+> Previously pick had no actions based on the entire thread: this adds\r
+> some. Note in this version '*' is bound to `tag thread' which is not\r
+> consistent with search or show. However it still might be the most\r
+> natural thing (as it is similar to running * in the show pane).\r
+\r
+Hmm. not sure about this. But since nobody complained in six months,\r
+let's go with it unless they wake up.\r
+\r
+> +  (setq tag-changes (funcall 'notmuch-tag\r
+> (notmuch-pick-get-messages-ids-thread-search) tag-changes))\r
+\r
+Why "(funcall 'notmuch-tag ...) instead of a "(notmuch-tag ...)" here?\r
+Personally I'd use let instead of setq here, but ymmv.\r
+\r
+> +Archive each message currently shown by applying the tag changes\r
+> +in `notmuch-archive-tags' to each (remove the \"inbox\" tag by\r
+> +default). If a prefix argument is given, the messages will be\r
+> +\"unarchived\", i.e. the tag changes in `notmuch-archive-tags'\r
+> +will be reversed.\r
+\r
+It seems to me the default value for notmuch-archive-tags should not be\r
+hard-coded into this docstring, especially since notmuch-archive-tags\r
+turns into a link in the help text.\r
+\r
+d\r