Re: [PATCH 1/2] cli: clean up exit status code returned by the cli commands
authorTomi Ollila <tomi.ollila@iki.fi>
Sat, 11 Jan 2014 10:22:52 +0000 (12:22 +0200)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:58:56 +0000 (09:58 -0800)
3a/541d1ad814b83c3f72a3f3cc954babccd4e4b1 [new file with mode: 0644]

diff --git a/3a/541d1ad814b83c3f72a3f3cc954babccd4e4b1 b/3a/541d1ad814b83c3f72a3f3cc954babccd4e4b1
new file mode 100644 (file)
index 0000000..de58489
--- /dev/null
@@ -0,0 +1,76 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 17F54431FC3\r
+       for <notmuch@notmuchmail.org>; Sat, 11 Jan 2014 02:23:05 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id lD-4Bb51g46x for <notmuch@notmuchmail.org>;\r
+       Sat, 11 Jan 2014 02:22:57 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 06D00431FC0\r
+       for <notmuch@notmuchmail.org>; Sat, 11 Jan 2014 02:22:57 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id A2B2910005E;\r
+       Sat, 11 Jan 2014 12:22:52 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/2] cli: clean up exit status code returned by the cli\r
+       commands\r
+In-Reply-To: <1389389334-24138-1-git-send-email-jani@nikula.org>\r
+References: <1389389334-24138-1-git-send-email-jani@nikula.org>\r
+User-Agent: Notmuch/0.17+23~ga575e35 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sat, 11 Jan 2014 12:22:52 +0200\r
+Message-ID: <m28uumyg03.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 11 Jan 2014 10:23:05 -0000\r
+\r
+On Fri, Jan 10 2014, Jani Nikula <jani@nikula.org> wrote:\r
+\r
+> Apart from the status codes for format mismatches, the non-zero exit\r
+> status codes have been arbitrary. Make the cli consistently return\r
+> either EXIT_SUCCESS or EXIT_FAILURE.\r
+> ---\r
+\r
+These 2 patches LGTM.\r
+\r
+Tomi\r
+\r
+\r
+>  notmuch-compact.c |  6 +++---\r
+>  notmuch-config.c  | 23 ++++++++++++++---------\r
+>  notmuch-count.c   | 16 +++++++---------\r
+>  notmuch-dump.c    | 21 +++++++++------------\r
+>  notmuch-insert.c  | 25 +++++++++++--------------\r
+>  notmuch-new.c     | 18 ++++++++----------\r
+>  notmuch-reply.c   | 20 +++++++++-----------\r
+>  notmuch-restore.c | 23 +++++++++--------------\r
+>  notmuch-search.c  | 18 ++++++++----------\r
+>  notmuch-setup.c   | 15 +++++++--------\r
+>  notmuch-show.c    | 18 ++++++++----------\r
+>  notmuch-tag.c     | 22 +++++++++++-----------\r
+>  notmuch.c         | 43 ++++++++++++++++++++++++++++---------------\r