Re: [PATCH] notmuch-show: include Bcc header in json output

diff --git a/57/6f20f93ca6576f6e6b44e078ed07ee89fd2a21 b/57/6f20f93ca6576f6e6b44e078ed07ee89fd2a21
new file mode 100644 (file)
index 0000000..b81394a
--- /dev/null
+++ b/57/6f20f93ca6576f6e6b44e078ed07ee89fd2a21
@@ -0,0 +1,99 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id D61D8431FAF\r
+       for <notmuch@notmuchmail.org>; Sat,  8 Sep 2012 04:29:49 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 59kYCxNScpga for <notmuch@notmuchmail.org>;\r
+       Sat,  8 Sep 2012 04:29:48 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 14316431FAE\r
+       for <notmuch@notmuchmail.org>; Sat,  8 Sep 2012 04:29:48 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id B871D1000E5;\r
+       Sat,  8 Sep 2012 14:29:53 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Michal Nazarewicz <mpn@google.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] notmuch-show: include Bcc header in json output\r
+In-Reply-To:\r
+ <e07afdc98fd9517fba3060970b1150cef4d7ac80.1346881123.git.mina86@mina86.com>\r
+References:\r
+ <e07afdc98fd9517fba3060970b1150cef4d7ac80.1346881123.git.mina86@mina86.com>\r
+User-Agent: Notmuch/0.14+11~gd9bf007 (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sat, 08 Sep 2012 14:29:53 +0300\r
+Message-ID: <m2zk50oiq6.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 08 Sep 2012 11:29:50 -0000\r
+\r
+On Thu, Sep 06 2012, Michal Nazarewicz <mpn@google.com> wrote:\r
+\r
+> From: Michal Nazarewicz <mina86@mina86.com>\r
+>\r
+> ---\r
+\r
+By looking the code (by applying this patch and looking more context)\r
+it looks good to me. If the commit message provided some explanation\r
+and use case *why* this patch is needed a casual reviewer who hasn't\r
+desired this feature (possibly by not knowing the benefits :) could\r
+understand the need better.\r
+\r
+Now that we have this bcc in json output when is it shown to the user ?\r
+\r
+Tomi\r
+\r
+>  notmuch-show.c |    7 +++++++\r
+>  1 files changed, 7 insertions(+), 0 deletions(-)\r
+>\r
+> Actually, I don't understand why json does not include all the\r
+> headers...\r
+>\r
+> diff --git a/notmuch-show.c b/notmuch-show.c\r
+> index 3556293..0b7abf1 100644\r
+> --- a/notmuch-show.c\r
+> +++ b/notmuch-show.c\r
+> @@ -233,6 +233,13 @@ format_headers_json (sprinter_t *sp, GMimeMessage *message,\r
+>      sp->string (sp, recipients_string);\r
+>      }\r
+>  \r
+> +    recipients = g_mime_message_get_recipients (message, GMIME_RECIPIENT_TYPE_BCC);\r
+> +    recipients_string = internet_address_list_to_string (recipients, 0);\r
+> +    if (recipients_string) {\r
+> +    sp->map_key (sp, "Bcc");\r
+> +    sp->string (sp, recipients_string);\r
+> +    }\r
+> +\r
+>      if (reply) {\r
+>      sp->map_key (sp, "In-reply-to");\r
+>      sp->string (sp, g_mime_object_get_header (GMIME_OBJECT (message), "In-reply-to"));\r
+> -- \r
+> 1.7.7.3\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r