Re: [PATCH 2/2] contrib: pick: thread tagging (including archiving) implemented

diff --git a/59/4b9c8bced0889e48af317aaf0d08112541a7e3 b/59/4b9c8bced0889e48af317aaf0d08112541a7e3
new file mode 100644 (file)
index 0000000..b562318
--- /dev/null
+++ b/59/4b9c8bced0889e48af317aaf0d08112541a7e3
@@ -0,0 +1,116 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 09634429E59\r
+       for <notmuch@notmuchmail.org>; Sat,  1 Jun 2013 14:45:42 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id APBTparPkFGM for <notmuch@notmuchmail.org>;\r
+       Sat,  1 Jun 2013 14:45:34 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id B72CC431FDE\r
+       for <notmuch@notmuchmail.org>; Sat,  1 Jun 2013 14:45:33 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1Uitc9-0003Pv-Dv; Sat, 01 Jun 2013 22:45:29 +0100\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1Uitc9-0004On-48; Sat, 01 Jun 2013 22:45:29 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 2/2] contrib: pick: thread tagging (including archiving)\r
+       implemented\r
+In-Reply-To: <87zjv91uki.fsf@zancas.localnet>\r
+References: <1354970914-18342-1-git-send-email-markwalters1009@gmail.com>\r
+       <1354970914-18342-3-git-send-email-markwalters1009@gmail.com>\r
+       <87zjv91uki.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.14+255~gff3cc55 (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 01 Jun 2013 22:45:27 +0100\r
+Message-ID: <87r4gly07c.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: cc5973d852c514d45253f4140caf3088 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -0.1\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored -0.1 points.\r
+       Summary of the scoring: \r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       * -0.1 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 01 Jun 2013 21:45:42 -0000\r
+\r
+\r
+Thanks for the review. A couple of comments below:\r
+\r
+On Sat, 01 Jun 2013, David Bremner <david@tethera.net> wrote:\r
+> Mark Walters <markwalters1009@gmail.com> writes:\r
+>\r
+>> Previously pick had no actions based on the entire thread: this adds\r
+>> some. Note in this version '*' is bound to `tag thread' which is not\r
+>> consistent with search or show. However it still might be the most\r
+>> natural thing (as it is similar to running * in the show pane).\r
+>\r
+> Hmm. not sure about this. But since nobody complained in six months,\r
+> let's go with it unless they wake up.\r
+\r
+Ok\r
+\r
+>> +  (setq tag-changes (funcall 'notmuch-tag\r
+>> (notmuch-pick-get-messages-ids-thread-search) tag-changes))\r
+>\r
+> Why "(funcall 'notmuch-tag ...) instead of a "(notmuch-tag ...)" here?\r
+> Personally I'd use let instead of setq here, but ymmv.\r
+\r
+I agree with both of these but this is almost identical code to that in\r
+notmuch-show-tag-all. \r
+\r
+>> +Archive each message currently shown by applying the tag changes\r
+>> +in `notmuch-archive-tags' to each (remove the \"inbox\" tag by\r
+>> +default). If a prefix argument is given, the messages will be\r
+>> +\"unarchived\", i.e. the tag changes in `notmuch-archive-tags'\r
+>> +will be reversed.\r
+>\r
+> It seems to me the default value for notmuch-archive-tags should not be\r
+> hard-coded into this docstring, especially since notmuch-archive-tags\r
+> turns into a link in the help text.\r
+\r
+I am happy either way on this one but again this is the same as\r
+notmuch-show-archive-thread.\r
+\r
+I think it's probably best to keep show and pick the same where they are\r
+similar but I can change the above if you disagree.\r
+\r
+Best wishes\r
+\r
+Mark\r