Re: [PATCH v2 1/1] notmuch-mutt: Fix tagging issues

diff --git a/fb/01ccfbfc2ae87f317c525bb828873b6b9c8a17 b/fb/01ccfbfc2ae87f317c525bb828873b6b9c8a17
new file mode 100644 (file)
index 0000000..7a2fd83
--- /dev/null
+++ b/fb/01ccfbfc2ae87f317c525bb828873b6b9c8a17
@@ -0,0 +1,72 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 91B21431FAF\r
+       for <notmuch@notmuchmail.org>; Sun,  8 Sep 2013 18:52:20 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id GsRXALngl7cW for <notmuch@notmuchmail.org>;\r
+       Sun,  8 Sep 2013 18:52:16 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id A05A4431FAE\r
+       for <notmuch@notmuchmail.org>; Sun,  8 Sep 2013 18:52:16 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1VIqeA-0000WH-SK; Sun, 08 Sep 2013 22:52:10 -0300\r
+Received: (nullmailer pid 6334 invoked by uid 1000); Mon, 09 Sep 2013\r
+       01:52:07 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: "Kevin J. McCarthy" <kevin@8t8.us>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 1/1] notmuch-mutt: Fix tagging issues\r
+In-Reply-To: <20130907170757.GA407@zaogao.lan>\r
+References: <20130906221520.GC4226@zaogao.lan>\r
+       <m2mwnprq7o.fsf@guru.guru-group.fi> <20130907155748.GD4226@zaogao.lan>\r
+       <20130907170757.GA407@zaogao.lan>\r
+User-Agent: Notmuch/0.16+37~g9701e9c (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 08 Sep 2013 22:52:07 -0300\r
+Message-ID: <87sixe3goo.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: Tomi Ollila <tomi.ollila@iki.fi>, Stefano Zacchiroli <zack@upsilon.cc>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 09 Sep 2013 01:52:20 -0000\r
+\r
+"Kevin J. McCarthy" <kevin@8t8.us> writes:\r
+\r
+> This patch fixes three issues with "notmuch-mutt tag":\r
+>\r
+> 1. The message_id was not shell quoted.\r
+>    Thanks to Jason Miller for the bug report and patch.\r
+>\r
+> 2. The tags passed into tag_action() were not being properly quoted.\r
+>    The "join before shell_quote" was combining multiple tags into a\r
+>    single argument to notmuch tag: '+one -two -three' instead of\r
+>    '+one' '-two' '-three'.\r
+>\r
+> 3. A "--" was added between the tags and search-term as shown in the\r
+>    current notmuch-tag man page.\r
+\r
+pushed.\r
+\r
+d\r