Re: [PATCH] notmuch-dump: use fsync instead of fdatasync
authorDavid Bremner <david@tethera.net>
Sat, 17 May 2014 21:46:08 +0000 (06:46 +0900)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 18:02:52 +0000 (10:02 -0800)
36/046f82f3a730a40ad1a2f76bf619548cf11489 [new file with mode: 0644]

diff --git a/36/046f82f3a730a40ad1a2f76bf619548cf11489 b/36/046f82f3a730a40ad1a2f76bf619548cf11489
new file mode 100644 (file)
index 0000000..90bd35f
--- /dev/null
@@ -0,0 +1,62 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 4B10D431FBF\r
+       for <notmuch@notmuchmail.org>; Sat, 17 May 2014 14:47:09 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id tnMuft7KgqEE for <notmuch@notmuchmail.org>;\r
+       Sat, 17 May 2014 14:47:02 -0700 (PDT)\r
+Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net\r
+       [87.98.215.224]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 318B3431FBC\r
+       for <notmuch@notmuchmail.org>; Sat, 17 May 2014 14:47:02 -0700 (PDT)\r
+Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim\r
+       4.72) (envelope-from <david@tethera.net>)\r
+       id 1WlmR4-00054Z-Ox; Sat, 17 May 2014 21:46:30 +0000\r
+Received: (nullmailer pid 19463 invoked by uid 1000); Sat, 17 May 2014\r
+       21:46:08 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] notmuch-dump: use fsync instead of fdatasync\r
+In-Reply-To: <1399550227-18488-1-git-send-email-david@tethera.net>\r
+References: <20140507171835.GA27619@mit.edu>\r
+       <1399550227-18488-1-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 18 May 2014 06:46:08 +0900\r
+Message-ID: <87vbt49izj.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 17 May 2014 21:47:09 -0000\r
+\r
+David Bremner <david@tethera.net> writes:\r
+\r
+> Since the file size will have changed, there is no performance benefit\r
+> to calling fdatasync.  Somewhat surprisingly, using fdatasync\r
+> apparently causes portability problems on FreeBSD.\r
+> ---\r
+\r
+pushed to release and master.\r
+\r
+d\r