Re: [PATCH] emacs: do not modify the alist passed to notmuch-sort-saved-searches

diff --git a/45/a1a306cc9412ec6b2e05d7219a4711ebe231e0 b/45/a1a306cc9412ec6b2e05d7219a4711ebe231e0
new file mode 100644 (file)
index 0000000..1260828
--- /dev/null
+++ b/45/a1a306cc9412ec6b2e05d7219a4711ebe231e0
@@ -0,0 +1,90 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id E4A25431E82\r
+       for <notmuch@notmuchmail.org>; Sun,  1 Apr 2012 10:09:43 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Az+wXl-Hg8cN for <notmuch@notmuchmail.org>;\r
+       Sun,  1 Apr 2012 10:09:42 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])\r
+       by olra.theworths.org (Postfix) with ESMTP id 94FF3431FAF\r
+       for <notmuch@notmuchmail.org>; Sun,  1 Apr 2012 10:09:42 -0700 (PDT)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id 9244D68055; Sun,  1 Apr 2012 20:09:38 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: do not modify the alist passed to\r
+       notmuch-sort-saved-searches\r
+In-Reply-To: <1333291883-1030-1-git-send-email-jani@nikula.org>\r
+References: <1333291883-1030-1-git-send-email-jani@nikula.org>User-Agent:\r
+ Notmuch/0.12+77~gee11800      (http://notmuchmail.org) Emacs/23.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sun, 01 Apr 2012 20:09:38 +0300\r
+Message-ID: <m2bonbidkd.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 01 Apr 2012 17:09:44 -0000\r
+\r
+On Sun, Apr 01 2012, Jani Nikula <jani@nikula.org> wrote:\r
+\r
+> Sort modifies its input as a side effect. Pass it a copy in\r
+> notmuch-sort-saved-searches to not modify the notmuch-saved-searches\r
+> alist.\r
+>\r
+> ---\r
+\r
++1 \r
+\r
+Tomi\r
+\r
+\r
+>\r
+> Earlier version by Daniel Schoepe and discussion in thread starting at\r
+> id:"1330633478-1974-1-git-send-email-daniel@schoepe.org".\r
+> ---\r
+>  emacs/notmuch-hello.el |    2 +-\r
+>  1 files changed, 1 insertions(+), 1 deletions(-)\r
+>\r
+> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el\r
+> index e9caade..8e37761 100644\r
+> --- a/emacs/notmuch-hello.el\r
+> +++ b/emacs/notmuch-hello.el\r
+> @@ -41,7 +41,7 @@\r
+>  \r
+>  (defun notmuch-sort-saved-searches (alist)\r
+>    "Generate an alphabetically sorted saved searches alist."\r
+> -  (sort alist (lambda (a b) (string< (car a) (car b)))))\r
+> +  (sort (copy-sequence alist) (lambda (a b) (string< (car a) (car b)))))\r
+>  \r
+>  (defcustom notmuch-saved-search-sort-function nil\r
+>    "Function used to sort the saved searches for the notmuch-hello view.\r
+> -- \r
+> 1.7.5.4\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r