Re: [PATCH v3 02/16] Move crypto.c into libutil

diff --git a/25/c34de86f0b50fad78969e860967f265c7c4ec8 b/25/c34de86f0b50fad78969e860967f265c7c4ec8
new file mode 100644 (file)
index 0000000..e1c3e66
--- /dev/null
+++ b/25/c34de86f0b50fad78969e860967f265c7c4ec8
@@ -0,0 +1,86 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 5D6516DE0231\r
+ for <notmuch@notmuchmail.org>; Tue,  9 Feb 2016 18:21:09 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.308\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.308 tagged_above=-999 required=5 tests=[AWL=0.243,\r
+  RP_MATCHES_RCVD=-0.55, SPF_PASS=-0.001] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id jCnQh-uiztbk for <notmuch@notmuchmail.org>;\r
+ Tue,  9 Feb 2016 18:21:07 -0800 (PST)\r
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 4CA6D6DE021E\r
+ for <notmuch@notmuchmail.org>; Tue,  9 Feb 2016 18:21:07 -0800 (PST)\r
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1aTKOE-0001Ro-Q5; Tue, 09 Feb 2016 21:20:22 -0500\r
+Received: (nullmailer pid 9755 invoked by uid 1000);\r
+ Wed, 10 Feb 2016 02:21:01 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,\r
+ Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH v3 02/16] Move crypto.c into libutil\r
+In-Reply-To: <1454272801-23623-3-git-send-email-dkg@fifthhorseman.net>\r
+References: <1454272801-23623-1-git-send-email-dkg@fifthhorseman.net>\r
+ <1454272801-23623-3-git-send-email-dkg@fifthhorseman.net>\r
+User-Agent: Notmuch/0.21+5~gca076ce (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Tue, 09 Feb 2016 22:21:01 -0400\r
+Message-ID: <87wpqduwz6.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 10 Feb 2016 02:21:09 -0000\r
+\r
+Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:\r
+\r
+> This prepares us for using the crypto object in both the library and\r
+> the client.\r
+>\r
+> i've prefixed notmuch_crypto with _ to indicate that while this can be\r
+> built into the library when needed, it's not something to be exported\r
+> or used externally.\r
+\r
+[...] snip\r
+\r
+> diff --git a/mime-node.c b/mime-node.c\r
+> index e96e663..a8f5670 100644\r
+> --- a/mime-node.c\r
+> +++ b/mime-node.c\r
+> @@ -33,7 +33,7 @@ typedef struct mime_node_context {\r
+>      GMimeMessage *mime_message;\r
+>  \r
+>      /* Context provided by the caller. */\r
+> -    notmuch_crypto_t *crypto;\r
+> +    _notmuch_crypto_t *crypto;\r
+>  } mime_node_context_t;\r
+\r
+is this maybe search and replace gone wild? or did you mean\r
+to rename the type as well as the functions?\r
+\r
+>  static void\r
+>  node_verify (mime_node_t *node, GMimeObject *part,\r
+> -         notmuch_crypto_context_t *cryptoctx)\r
+> +         GMimeCryptoContext *cryptoctx)\r
+>  {\r
+\r
+This change of parameter type seems significant. Does it deserve a\r
+comment in the commit message?\r
+\r