Re: [PATCH] make test: NOTMUCH_TEST_QUIET=1 is now the default

diff --git a/19/a06604952a8fb27954f775169617fca1529443 b/19/a06604952a8fb27954f775169617fca1529443
new file mode 100644 (file)
index 0000000..33b0932
--- /dev/null
+++ b/19/a06604952a8fb27954f775169617fca1529443
@@ -0,0 +1,80 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 0E5F46DE1AE0\r
+ for <notmuch@notmuchmail.org>; Sun, 20 Sep 2015 04:36:12 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.114\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.114 tagged_above=-999 required=5 tests=[AWL=0.114]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id Y8PjE9KWzh4y for <notmuch@notmuchmail.org>;\r
+ Sun, 20 Sep 2015 04:36:10 -0700 (PDT)\r
+Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 072816DE1ADF\r
+ for <notmuch@notmuchmail.org>; Sun, 20 Sep 2015 04:36:09 -0700 (PDT)\r
+Received: from remotemail by gitolite.debian.net with local (Exim 4.80)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1Zdctk-0006gf-N4; Sun, 20 Sep 2015 11:35:12 +0000\r
+Received: (nullmailer pid 15237 invoked by uid 1000); Sun, 20 Sep 2015\r
+ 11:31:16 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] make test: NOTMUCH_TEST_QUIET=1 is now the default\r
+In-Reply-To: <1442004251-32325-1-git-send-email-tomi.ollila@iki.fi>\r
+References: <1442004251-32325-1-git-send-email-tomi.ollila@iki.fi>\r
+User-Agent: Notmuch/0.20.2+73~gd432116 (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sun, 20 Sep 2015 08:31:16 -0300\r
+Message-ID: <87io75tji3.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: tomi.ollila@iki.fi\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.18\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 20 Sep 2015 11:36:12 -0000\r
+\r
+Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+\r
+> make test V=1 (or any other value than 0) and make test V=0\r
+> works similar way as build in general\r
+> ---\r
+>\r
+> This is 2nd try: In first one I changed test-lib.sh -- there problem\r
+> was the precedence between command line argument and NOTMUCH_TEST_QUIET\r
+> environment variable. Here I don't see a problem there (although\r
+> env NOTMUCH_TEST_QUIET=1 make test V=1 will make environment variable\r
+> overrule the V=1 -- I am not sure who cares, though :D)\r
+>\r
+> Anyway, Someone(TM) may have better solution in mind, so let's\r
+> get bikeshedding going!\r
+>\r
+\r
+One thing I thought of was that we could replace the use of\r
+NOTMUCH_TEST_QUIET with e.g. NOTMUCH_TEST_VERBOSE, and have that set by\r
+the command line argument --verbose.  This would be less work on the\r
+Makefile side, but I guess a bit more on the test-lib.sh side. I suppose\r
+it might also be an annoyance for some people currently using\r
+NOTMUCH_TEST_QUIET in some autobuilder setup. At the moment I can't\r
+think of what would really break by changing this "API", but knows. The\r
+current behaviour of having NOTMUCH_TEST_QUIET and --verbose completely\r
+independent is pretty surprising.\r
+\r
+d\r
+\r
+P.S. I hope you appreciate my classic "scope-creep" technique in\r
+bikeshedding. ;)\r