Re: [PATCH] emacs: bugfix attachment content-type as mime-type handling

diff --git a/c0/1b1a20494b9dba6053a94fb9d896a4b780f1c8 b/c0/1b1a20494b9dba6053a94fb9d896a4b780f1c8
new file mode 100644 (file)
index 0000000..bff7a1f
--- /dev/null
+++ b/c0/1b1a20494b9dba6053a94fb9d896a4b780f1c8
@@ -0,0 +1,84 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 39137431FC0\r
+       for <notmuch@notmuchmail.org>; Tue, 30 Jul 2013 14:00:26 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id V-TwCPDis0Ci for <notmuch@notmuchmail.org>;\r
+       Tue, 30 Jul 2013 14:00:17 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id A0D96431FBF\r
+       for <notmuch@notmuchmail.org>; Tue, 30 Jul 2013 14:00:17 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 38D70100033;\r
+       Wed, 31 Jul 2013 00:00:08 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: bugfix attachment content-type as mime-type\r
+       handling\r
+In-Reply-To: <1375200900-5650-1-git-send-email-markwalters1009@gmail.com>\r
+References: <87li4om623.fsf@qmul.ac.uk>\r
+       <1375200900-5650-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.15.2+225~g6062adf (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 31 Jul 2013 00:00:07 +0300\r
+Message-ID: <m2txjbepbc.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 30 Jul 2013 21:00:26 -0000\r
+\r
+On Tue, Jul 30 2013, Mark Walters <markwalters1009@gmail.com> wrote:\r
+\r
+> Notmuch puts attachments in as declared content-type except when the\r
+> content-type is application/octet-stream it tries to guess the type\r
+> from the filename/extension. This means that viewing a pdf (for\r
+> example) which is sent as application/octet-strem invokes the pdf\r
+> viewer rather than just offering to save the part.\r
+>\r
+> Recent changes to the attachment handling (commit 1546387d) changed\r
+> (broke) this. This patch stores the calculated mime-type with the part\r
+> and changes the attachment part handlers can use it instead.\r
+> ---\r
+> This seems to fix the bug for me. I am not sure I like the naming\r
+> (mime-type/content-type). Maybe it would be better to be explicit with\r
+> something like calculated-content-type but probably that should be a\r
+> more wholesale renaming.\r
+\r
+I tested this (before and after applying the patch), using notmuch\r
+remotely and viewing id:87ppu0t7yf.fsf@qmul.ac.uk .\r
+Before applying emacs promted me an output file, after applying xdg-open\r
+was executed - which executed evince to show the pdf document in that email.\r
+\r
+If this restores the behaviour that was experienced with notmuch 0.15(.2)\r
+then this imho is a good fix to be applied quickly before 0.16 is released...\r
+\r
+>\r
+> Best wishes\r
+>\r
+> Mark\r
+\r
+Tomi\r
+\r