Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons

diff --git a/7f/d8f0f82301e1ef92df8dbb2449a12cd3a5efa8 b/7f/d8f0f82301e1ef92df8dbb2449a12cd3a5efa8
new file mode 100644 (file)
index 0000000..12b0969
--- /dev/null
+++ b/7f/d8f0f82301e1ef92df8dbb2449a12cd3a5efa8
@@ -0,0 +1,86 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 6CC88431FBC\r
+       for <notmuch@notmuchmail.org>; Tue,  4 Feb 2014 02:31:50 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 9Ed5XVpVfoQc for <notmuch@notmuchmail.org>;\r
+       Tue,  4 Feb 2014 02:31:44 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8DB3A431FAF\r
+       for <notmuch@notmuchmail.org>; Tue,  4 Feb 2014 02:31:44 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 9BBEF100033;\r
+       Tue,  4 Feb 2014 12:31:36 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: "W. Trevor King" <wking@tremily.us>\r
+Subject: Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for\r
+       part buttons\r
+In-Reply-To: <20140204001430.GP14197@odin.tremily.us>\r
+References: <877g9chbay.fsf@qmul.ac.uk>\r
+ <cover.1391423201.git.wking@tremily.us>\r
+       <27be295875a7df782a83c9a2c09d06f9d321fe9e.1391423201.git.wking@tremily.us>\r
+       <m2k3dcq62w.fsf@guru.guru-group.fi>     <20140204001430.GP14197@odin.tremily.us>\r
+User-Agent: Notmuch/0.17+55~g4397960 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Tue, 04 Feb 2014 12:31:36 +0200\r
+Message-ID: <m2eh3jp3sn.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 04 Feb 2014 10:31:50 -0000\r
+\r
+On Tue, Feb 04 2014, "W. Trevor King" <wking@tremily.us> wrote:\r
+\r
+> On Mon, Feb 03, 2014 at 10:44:39PM +0200, Tomi Ollila wrote:\r
+>> having notmuch patch email as expected test output feels a bit\r
+>> confusing to me -- especially as 'git grep' may catch some of the\r
+>> (possibly future-outdated) content...\r
+>\r
+> There were two very similar patches with filename attachments in the\r
+> corpus, so I used them for the tests ;).  I can convert that test to\r
+> use emacs_fcc_message or some other auto-generated content if you'd\r
+> prefer.\r
+\r
+You're right; corpus seems to be full of notmuch patch emails...\r
+\r
+\r
+... and (although?) (just noticed)...\r
+\r
+$ grep '^ *[+-].*\<if\>' test/* test/*/*\r
+test/emacs.expected-output/attachment:+    if (pw_buf_size == -1)\r
+pw_buf_size = 64;\r
+test/emacs.expected-output/attachment:+    if (pw_buf_size == -1)\r
+pw_buf_size = 64;\r
+\r
+... I am not giving much resistance to keep the patch as it is :D\r
+\r
+>\r
+> Cheers,\r
+> Trevor\r
+>\r
+\r
+Tomi\r