Bug #269225 - Warn about virtuals with non-empty HOMEPAGE or LICENSE. Thanks

to Ulrich Müller <ulm@g.o> for this patch. (trunk r15174)

svn path=/main/branches/2.1.7/; revision=15240

diff --git a/bin/repoman b/bin/repoman
index b6237819752b8739a6a51de745552ca81cc91558..49f04c6e9f0f57e49a1302cc30107e56f3c742a0 100755 (executable)
--- a/bin/repoman
+++ b/bin/repoman
@@ -278,6 +278,7 @@ qahelp={
        "KEYWORDS.stable":"Ebuilds that have been added directly with stable KEYWORDS",
        "KEYWORDS.stupid":"Ebuilds that use KEYWORDS=-* instead of package.mask", 
        "LICENSE.missing":"Ebuilds that have a missing or empty LICENSE variable",
+       "LICENSE.virtual":"Virtuals that have a non-empty LICENSE variable",
        "DESCRIPTION.missing":"Ebuilds that have a missing or empty DESCRIPTION variable",
        "DESCRIPTION.toolong":"DESCRIPTION is over %d characters" % max_desc_len,
        "EAPI.definition":"EAPI is defined after an inherit call (must be defined before)",
@@ -285,6 +286,7 @@ qahelp={
        "EAPI.unsupported":"Ebuilds that have an unsupported EAPI version (you must upgrade portage)",
        "SLOT.invalid":"Ebuilds that have a missing or invalid SLOT variable value",
        "HOMEPAGE.missing":"Ebuilds that have a missing or empty HOMEPAGE variable",
+       "HOMEPAGE.virtual":"Virtuals that have a non-empty HOMEPAGE variable",
        "DEPEND.bad":"User-visible ebuilds with bad DEPEND settings (matched against *visible* ebuilds)",
        "RDEPEND.bad":"User-visible ebuilds with bad RDEPEND settings (matched against *visible* ebuilds)",
        "PDEPEND.bad":"User-visible ebuilds with bad PDEPEND settings (matched against *visible* ebuilds)",
@@ -360,6 +362,8 @@ qawarnings = set((
 "DEPEND.badmaskedindev","RDEPEND.badmaskedindev","PDEPEND.badmaskedindev",
 "DEPEND.badtilde", "RDEPEND.badtilde", "PDEPEND.badtilde",
 "DESCRIPTION.toolong",
+"HOMEPAGE.virtual",
+"LICENSE.virtual",
 "KEYWORDS.dropped",
 "KEYWORDS.stupid",
 "KEYWORDS.missing",
@@ -1381,6 +1385,13 @@ for x in scanlist:
                                stats[myqakey]=stats[myqakey]+1
                                fails[myqakey].append(x+"/"+y+".ebuild")
 
+               if catdir == "virtual":
+                       for var in ("HOMEPAGE", "LICENSE"):
+                               if myaux.get(var):
+                                       myqakey = var + ".virtual"
+                                       stats[myqakey] = stats[myqakey] + 1
+                                       fails[myqakey].append(relative_path)
+
                # 14 is the length of DESCRIPTION=""
                if len(myaux['DESCRIPTION']) > max_desc_len:
                        stats['DESCRIPTION.toolong'] += 1

diff --git a/man/repoman.1 b/man/repoman.1
index ab54f5bdabaddeb070408771e91df2bcee492743..3f8f1c5e64b83fb18d3c638da576332f7dd9ab54 100644 (file)
--- a/man/repoman.1
+++ b/man/repoman.1
@@ -119,6 +119,9 @@ Ebuilds that have an unsupported EAPI version (you must upgrade portage)
 .B HOMEPAGE.missing
 Ebuilds that have a missing or empty HOMEPAGE variable
 .TP
+.B HOMEPAGE.virtual
+Virtuals that have a non-empty HOMEPAGE variable
+.TP
 .B IUSE.invalid
 This ebuild has a variable in IUSE that is not in the use.desc or its metadata.xml file
 .TP
@@ -149,6 +152,9 @@ Ebuilds that have a missing or empty LICENSE variable
 .B LICENSE.syntax
 Syntax error in LICENSE (usually an extra/missing space/parenthesis)
 .TP
+.B LICENSE.virtual
+Virtuals that have a non-empty LICENSE variable
+.TP
 .B LIVEVCS.stable
 Ebuild is a live ebuild (cvs, git, darcs, svn, etc) checkout with stable keywords.
 .TP