Re: [PATCH 5/6] emacs: simplify `notmuch-show-get-messages-ids{, -search}'

diff --git a/de/23a6a70473eea2e567d8e0a48736b9f746f5a6 b/de/23a6a70473eea2e567d8e0a48736b9f746f5a6
new file mode 100644 (file)
index 0000000..a34b1a2
--- /dev/null
+++ b/de/23a6a70473eea2e567d8e0a48736b9f746f5a6
@@ -0,0 +1,145 @@
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 86712417332\r
+       for <notmuch@notmuchmail.org>; Fri, 24 Feb 2012 02:44:19 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 1J9hYhagncjt for <notmuch@notmuchmail.org>;\r
+       Fri, 24 Feb 2012 02:44:19 -0800 (PST)\r
+Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com\r
+       [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id AD997417330\r
+       for <notmuch@notmuchmail.org>; Fri, 24 Feb 2012 02:44:18 -0800 (PST)\r
+Received: by bkcit16 with SMTP id it16so2023133bkc.26\r
+       for <notmuch@notmuchmail.org>; Fri, 24 Feb 2012 02:44:17 -0800 (PST)\r
+Received-SPF: pass (google.com: domain of dmitry.kurochkin@gmail.com\r
+       designates 10.205.127.130 as permitted sender)\r
+       client-ip=10.205.127.130; \r
+Authentication-Results: mr.google.com; spf=pass (google.com: domain of\r
+       dmitry.kurochkin@gmail.com designates 10.205.127.130 as\r
+       permitted sender) smtp.mail=dmitry.kurochkin@gmail.com;\r
+       dkim=pass header.i=dmitry.kurochkin@gmail.com\r
+Received: from mr.google.com ([10.205.127.130])\r
+       by 10.205.127.130 with SMTP id ha2mr849783bkc.28.1330080257256\r
+       (num_hops = 1); Fri, 24 Feb 2012 02:44:17 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+       h=from:to:cc:subject:in-reply-to:references:user-agent:date\r
+       :message-id:mime-version:content-type;\r
+       bh=N53Q/VC1UW4XoBG7ClauPBsxrcjQZNRdP9Y/HHxAQMk=;\r
+       b=PZihcSANEcMbkUjBTVLdpuw6g9sK/jkqla0hIgf1qXEP548FEsBDB22ZvtwC5GFsxu\r
+       v0fenKCVtUi1da3TckrCmrSwv85BiYxmLUYAG+wzMBmBVim31OyYbvV5W19PLNBRICrX\r
+       +faVdNcqlMxaQGbglUeiGEYBZeP/GIKddLCoA=\r
+Received: by 10.205.127.130 with SMTP id ha2mr707195bkc.28.1330080257191;\r
+       Fri, 24 Feb 2012 02:44:17 -0800 (PST)\r
+Received: from localhost ([91.144.186.21])\r
+       by mx.google.com with ESMTPS id i2sm7867207bkd.10.2012.02.24.02.44.16\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Fri, 24 Feb 2012 02:44:16 -0800 (PST)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: Pieter Praet <pieter@praet.org>, David Bremner <david@tethera.net>\r
+Subject: Re: [PATCH 5/6] emacs: simplify `notmuch-show-get-messages-ids{,\r
+       -search}'\r
+In-Reply-To: <1330038554-10347-5-git-send-email-pieter@praet.org>\r
+References: <878vjtqhcg.fsf@praet.org>\r
+       <1330038554-10347-5-git-send-email-pieter@praet.org>\r
+User-Agent: Notmuch/0.11.1+188~ga5674c2 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Fri, 24 Feb 2012 14:42:53 +0400\r
+Message-ID: <87d394jyvm.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 24 Feb 2012 10:44:19 -0000\r
+\r
+On Fri, 24 Feb 2012 00:09:13 +0100, Pieter Praet <pieter@praet.org> wrote:\r
+> * emacs/notmuch-show.el\r
+> \r
+>   (notmuch-show-get-messages-ids):\r
+>     If provided with optional arg SEPARATOR, return a string consisting\r
+>     of all Message-Id's, separated by SEPARATOR.  Also improve original\r
+>     docstring wrt default return value.\r
+> \r
+>   (notmuch-show-get-messages-ids-search):\r
+>     Removed, as its functionality is now in `notmuch-show-get-messages-ids'.\r
+> \r
+>   (notmuch-show-tag-all):\r
+>     Call `notmuch-show-get-messages-ids' with SEPARATOR arg instead of\r
+>     `notmuch-show-get-messages-ids-search'.\r
+> ---\r
+\r
+There is another similar case in notmuch.el:\r
+`notmuch-show-get-messages-ids' and\r
+`notmuch-show-get-messages-ids-search'.  There may be more.\r
+\r
+Please change them as well.\r
+\r
+Regards,\r
+  Dmitry\r
+\r
+>  emacs/notmuch-show.el |   18 +++++++++---------\r
+>  1 files changed, 9 insertions(+), 9 deletions(-)\r
+> \r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index 5fc0e43..4b37c77 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -1334,17 +1334,17 @@ (defun notmuch-show-get-message-id ()\r
+>    "Return the message id of the current message."\r
+>    (concat "id:\"" (notmuch-show-get-prop :id) "\""))\r
+>  \r
+> -(defun notmuch-show-get-messages-ids ()\r
+> -  "Return all message ids of messages in the current thread."\r
+> +(defun notmuch-show-get-messages-ids (&optional separator)\r
+> +  "Return a list of Message-Id's of all messages in the current buffer.\r
+> +\r
+> +If provided with optional argument SEPARATOR, return a string\r
+> +instead, consisting of all Message-Id's separated by SEPARATOR."\r
+>    (let ((message-ids))\r
+>      (notmuch-show-mapc t\r
+>       (lambda () (push (notmuch-show-get-message-id) message-ids)))\r
+> -    message-ids))\r
+> -\r
+> -(defun notmuch-show-get-messages-ids-search ()\r
+> -  "Return a search string for all message ids of messages in the\r
+> -current thread."\r
+> -  (mapconcat 'identity (notmuch-show-get-messages-ids) " or "))\r
+> +    (if separator\r
+> +    (mapconcat 'identity message-ids separator)\r
+> +      message-ids)))\r
+>  \r
+>  ;; dme: Would it make sense to use a macro for many of these?\r
+>  \r
+> @@ -1633,7 +1633,7 @@ (defun notmuch-show-tag-all (&rest tag-changes)\r
+>  \r
+>  TAG-CHANGES is a list of tag operations for `notmuch-tag'."\r
+>    (interactive (notmuch-read-tag-changes nil notmuch-show-thread-id))\r
+> -  (apply 'notmuch-tag (notmuch-show-get-messages-ids-search) tag-changes)\r
+> +  (apply 'notmuch-tag (notmuch-show-get-messages-ids " or ") tag-changes)\r
+>    (notmuch-show-mapc t\r
+>     (lambda ()\r
+>       (let* ((current-tags (notmuch-show-get-tags))\r
+> -- \r
+> 1.7.8.1\r
+> \r