--- /dev/null
+Return-Path: <imain@redhat.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 1032C431FAF\r
+ for <notmuch@notmuchmail.org>; Mon, 6 Oct 2014 21:17:07 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id OCITKx3T+46O for <notmuch@notmuchmail.org>;\r
+ Mon, 6 Oct 2014 21:16:59 -0700 (PDT)\r
+Received: from cmta19.telus.net (cmta19.telus.net [209.171.16.92])\r
+ by olra.theworths.org (Postfix) with ESMTP id ACB04431FAE\r
+ for <notmuch@notmuchmail.org>; Mon, 6 Oct 2014 21:16:59 -0700 (PDT)\r
+Received: from ovo.mains.priv ([207.102.88.62]) by cmta19.telus.net with TELUS\r
+ id 04Gw1p00A1LiWEf014GwRu; Mon, 06 Oct 2014 22:16:58 -0600\r
+X-Authority-Analysis: v=2.0 cv=fJznK+me c=1 sm=2\r
+ a=EcQDfIwDZEqJA1f7rVUV8Q==:17 a=S-IsBHyFrF4A:10 a=IkcTkHD0fZMA:10\r
+ a=tsa3CZZnAAAA:8 a=YrYOZUNBYV6lC7RO51gA:9 a=QEXdDO2ut3YA:10\r
+ a=P87eogJZi2UA:10 a=EcQDfIwDZEqJA1f7rVUV8Q==:117\r
+X-Telus-Outbound-IP: 207.102.88.62\r
+Received: from ovo.mains.priv (localhost.localdomain [127.0.0.1])\r
+ by ovo.mains.priv (8.14.8/8.14.8) with ESMTP id s974Grn9032621;\r
+ Mon, 6 Oct 2014 21:16:53 -0700\r
+Received: (from imain@localhost)\r
+ by ovo.mains.priv (8.14.8/8.14.8/Submit) id s974GqdY032620;\r
+ Mon, 6 Oct 2014 21:16:52 -0700\r
+X-Authentication-Warning: ovo.mains.priv: imain set sender to imain@redhat.com\r
+ using -f\r
+Date: Mon, 06 Oct 2014 21:16:52 -0700\r
+From: Ian Main <imain@stemwinder.org>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Message-ID: <5433693499518_7e54e45e9424@ovo.mains.priv.notmuch>\r
+In-Reply-To: <m27g0dt5lk.fsf@guru.guru-group.fi>\r
+References: <1412617904-27252-1-git-send-email-imain@stemwinder.org>\r
+ <1412619036-29203-1-git-send-email-imain@stemwinder.org>\r
+ <m27g0dt5lk.fsf@guru.guru-group.fi>\r
+Subject: Re: [PATCH] VIM: Make an option to save sent mail locally\r
+Mime-Version: 1.0\r
+Content-Type: text/plain;\r
+ charset=utf-8\r
+Content-Transfer-Encoding: 7bit\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 07 Oct 2014 04:17:07 -0000\r
+\r
+Tomi Ollila wrote:\r
+> On Mon, Oct 06 2014, Ian Main <imain@stemwinder.org> wrote:\r
+> \r
+> > Add an option to use 'notmuch insert' to save your sent mail.\r
+> > ---\r
+> >\r
+> > Add -inbox as well.\r
+> >\r
+> > vim/notmuch.vim | 17 +++++++++++++++++\r
+> > 1 file changed, 17 insertions(+)\r
+> >\r
+> > diff --git a/vim/notmuch.vim b/vim/notmuch.vim\r
+> > index 331e930..a9044c4 100644\r
+> > --- a/vim/notmuch.vim\r
+> > +++ b/vim/notmuch.vim\r
+> > @@ -58,6 +58,7 @@ let s:notmuch_date_format_default = '%d.%m.%y'\r
+> > let s:notmuch_datetime_format_default = '%d.%m.%y %H:%M:%S'\r
+> > let s:notmuch_reader_default = 'mutt -f %s'\r
+> > let s:notmuch_sendmail_default = 'sendmail'\r
+> > +let s:notmuch_save_sent_locally_default = 1\r
+> > let s:notmuch_folders_count_threads_default = 0\r
+> > \r
+> > function! s:new_file_buffer(type, fname)\r
+> > @@ -108,6 +109,18 @@ EOF\r
+> > echohl None\r
+> > return\r
+> > endif\r
+> \r
+> AFAIU looks mmm. readable ;)\r
+> \r
+> > +\r
+> > + if g:notmuch_save_sent_locally\r
+> > + let out = system('cat ' . fname . ' | notmuch insert --create-folder --folder=Sent +sent -unread -inbox')\r
+> \r
+> as this is (looks like) shell invocation, this could be in format\r
+> \r
+> let out = system('notmuch insert --create-folder --folder=Sent +sent -unread -inbox < ' . fname)\r
+\r
+You are right, that's better.\r
+\r
+> or even \r
+> \r
+> let out = system('exec notmuch insert --create-folder --folder=Sent +sent -unread -inbox < ' . fname)\r
+> \r
+> (well, the latter would be out of the status quo)\r
+> \r
+> Ok, I looked a bit into the notmuch.vim -code, and noticed sometimes\r
+> system() command lines use "notmuch" and sometimes g:notmuch_cmd \r
+> -- I think the latter should be used in new code and the previous ones\r
+> should be fixed.\r
+> \r
+> i.e. system ( g:notmuch_cmd . ' insert ... ' < . fname)\r
+> \r
+> Totally untested from my part...\r
+> \r
+> When the change alike this lands to the notmuch repository this needs NEWS\r
+> item which informs that from now sent mails are notmuch-inserted to\r
+> user's mail store (as this seems to be the default...) -- well, let's see\r
+> that when there are real reviewers (i.e. those who are interested to and can\r
+> test this).\r
+\r
+Also a good suggestion. From what I see they always use 'notmuch' straight up\r
+which is probably a reasonable assumption. I do think the actual init code for\r
+vim could have a few more checks, such as verifying that 'notmuch' is in $PATH\r
+etc. \r
+\r
+Thanks for the review!! I'll send out a new rev tomorrow - very tired right now.\r
+\r
+ Ian\r
projects / notmuch-archives.git / commitdiff