Re: [PATCH 1/2] Build symbol-test with make instead of hardcoding in symbol-hiding.

diff --git a/6e/d17f9323bbda50e08a9f6992f43c317be6cc79 b/6e/d17f9323bbda50e08a9f6992f43c317be6cc79
new file mode 100644 (file)
index 0000000..c76ea57
--- /dev/null
+++ b/6e/d17f9323bbda50e08a9f6992f43c317be6cc79
@@ -0,0 +1,130 @@
+Return-Path: <aidecoe@aidecoe.name>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id B5643431FD0\r
+       for <notmuch@notmuchmail.org>; Fri, 25 Nov 2011 07:12:30 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id b4kYE-tvcvNR for <notmuch@notmuchmail.org>;\r
+       Fri, 25 Nov 2011 07:12:30 -0800 (PST)\r
+Received: from mail-bw0-f53.google.com (mail-bw0-f53.google.com\r
+       [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id EE146431FB6\r
+       for <notmuch@notmuchmail.org>; Fri, 25 Nov 2011 07:12:29 -0800 (PST)\r
+Received: by bkaq10 with SMTP id q10so4872190bka.26\r
+       for <notmuch@notmuchmail.org>; Fri, 25 Nov 2011 07:12:28 -0800 (PST)\r
+Received: by 10.204.8.77 with SMTP id g13mr32869970bkg.89.1322233948092;\r
+       Fri, 25 Nov 2011 07:12:28 -0800 (PST)\r
+Received: from localhost (abtw56.neoplus.adsl.tpnet.pl. [83.8.168.56])\r
+       by mx.google.com with ESMTPS id e20sm28864703fab.2.2011.11.25.07.12.25\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Fri, 25 Nov 2011 07:12:26 -0800 (PST)\r
+From: =?utf-8?q?Amadeusz_=C5=BBo=C5=82nowski?= <aidecoe@aidecoe.name>\r
+To: David Bremner <david@tethera.net>\r
+Subject: Re: [PATCH 1/2] Build symbol-test with make instead of hardcoding in\r
+       symbol-hiding.\r
+In-reply-to: <878vn4bbf7.fsf@convex-new.cs.unb.ca>\r
+References: <1322218492-8300-1-git-send-email-aidecoe@aidecoe.name>\r
+       <878vn4bbf7.fsf@convex-new.cs.unb.ca>\r
+Date: Fri, 25 Nov 2011 16:12:24 +0100\r
+Message-Id: <1322233411-sup-6651@ittemni>\r
+User-Agent: Sup/git\r
+Content-Transfer-Encoding: 8bit\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; protocol="application/pgp-signature";\r
+       boundary="=-1322233944-445180-28641-4206-1-="\r
+Cc: notmuch <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 25 Nov 2011 15:12:30 -0000\r
+\r
+\r
+--=-1322233944-445180-28641-4206-1-=\r
+Content-Type: text/plain; charset=UTF-8\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+Excerpts from David Bremner's message of 2011-11-25 14:04:44 +0100:\r
+> On Fri, 25 Nov 2011 11:54:51 +0100, Amadeusz =C5=BBo=C5=82nowski <aidec=\r
+oe@aidecoe.name> wrote:\r
+> >  =\r
+\r
+> > +$(dir)/symbol-test: $(dir)/symbol-test.o\r
+> > +    $(call quiet,CC) $^ -o $@ -Llib -lnotmuch -lxapian\r
+> =\r
+\r
+> I'm a bit surprised no -I is neaded here. Is that taken care in the CC\r
+> call?\r
+\r
+-I is for headers which are not used when linking.  symbol-test.o is\r
+compiled according to rule defined earlier in some parent Makefile.\r
+\r
+\r
+> >  .PHONY: test check\r
+> > -test:    all $(dir)/smtp-dummy\r
+> > +test:    all $(dir)/smtp-dummy $(dir)/symbol-test\r
+> >      @${dir}/notmuch-test $(OPTIONS)\r
+> =\r
+\r
+> The instructions were already wrong, but maybe they should be updated t=\r
+o\r
+> point out that calling the test scripts directly requires smtp-dummy an=\r
+d\r
+> symbol-test already be built. Or maybe the tests should check for these=\r
+\r
+> binaries as pre-reqs along with emacs, gpg, etc... =\r
+\r
+> =\r
+\r
+> > +       -e "/^(emacs.expected-output|smtp-dummy|smtp-dummy.c|test-ver=\r
+bose|symbol-test.cc|symbol-test|symbol-test.o)/d" \\r
+> =\r
+\r
+> I wonder if this should be shortened (and made a bit sloppier) with the=\r
+\r
+> use of regexes.\r
+\r
+Thanks it's so straightforward.  I found this line quickly without deep\r
+analysis of all test-framework. :-)  It could only be made more flexible\r
+- put list of this files into some separate text file.  But that's\r
+subject for another patch.  Purpose of this one is to make building out\r
+of tree working.\r
+\r
+\r
+--\r
+Amadeusz =C5=BBo=C5=82nowski\r
+\r
+--=-1322233944-445180-28641-4206-1-=\r
+Content-Disposition: attachment; filename="signature.asc"\r
+Content-Type: application/pgp-signature; name="signature.asc"\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v2.0.18 (GNU/Linux)\r
+\r
+iQEcBAEBAgAGBQJOz7BYAAoJEPATRTHh2/q1sJUIAIBRHA27PddyBEm/+xYFQp+m\r
+3m6AkOBNtxjZ11DOxFD5Yva98De3/mmwnvn0xCj9DcRT+lXZamxE1BU22TouxMRx\r
+J7FFuUVX1DP9EJPnGfc3P0ZKlcEGWKKLSSL0lt38IoWEK4mmUY/XjTSuhh8B5v/4\r
++0T7pWeU/TBS0U7pEr/z2AtzODq9PMP771BzHGzrevIeDul3RJ390g55h5Vlo5oa\r
+jYELaqPSx5C2tuLzBWJ0LVhDGVRtp/YpQw973ltKJz4vyPgU87h4AjNYvj8CYj/B\r
+qsX15qljqbNnGK8WeRKH2poKLCVFrG9OpXvhYX4UWBuXuRxiVqBil+eFxfLVR0E=\r
+=d64X\r
+-----END PGP SIGNATURE-----\r
+\r
+--=-1322233944-445180-28641-4206-1-=--\r