Re: [PATCH v2] VIM: Use notmuch CLI for config

diff --git a/70/4cab10e2cedae4e112ed7d0c0c69fa595dc27d b/70/4cab10e2cedae4e112ed7d0c0c69fa595dc27d
new file mode 100644 (file)
index 0000000..8e0fb35
--- /dev/null
+++ b/70/4cab10e2cedae4e112ed7d0c0c69fa595dc27d
@@ -0,0 +1,96 @@
+Return-Path: <imain@redhat.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id A85F9431FBC\r
+       for <notmuch@notmuchmail.org>; Fri,  3 Oct 2014 11:41:30 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id guVlFOMdp+5l for <notmuch@notmuchmail.org>;\r
+       Fri,  3 Oct 2014 11:41:23 -0700 (PDT)\r
+Received: from cmta18.telus.net (cmta18.telus.net [209.171.16.91])\r
+       by olra.theworths.org (Postfix) with ESMTP id 67ACC431FB6\r
+       for <notmuch@notmuchmail.org>; Fri,  3 Oct 2014 11:41:23 -0700 (PDT)\r
+Received: from ovo.mains.priv ([207.102.88.62]) by cmta18.telus.net with TELUS\r
+       id yihM1o00c1LiWEf01ihMB4; Fri, 03 Oct 2014 12:41:22 -0600\r
+X-Authority-Analysis: v=2.0 cv=GdvJa3rL c=1 sm=2\r
+       a=EcQDfIwDZEqJA1f7rVUV8Q==:17 a=S-IsBHyFrF4A:10 a=IkcTkHD0fZMA:10\r
+       a=tsa3CZZnAAAA:8 a=9IXG43mSqOdJ_MyTbwwA:9 a=QEXdDO2ut3YA:10\r
+       a=P87eogJZi2UA:10 a=EcQDfIwDZEqJA1f7rVUV8Q==:117\r
+X-Telus-Outbound-IP: 207.102.88.62\r
+Received: from ovo.mains.priv (localhost.localdomain [127.0.0.1])\r
+       by ovo.mains.priv (8.14.8/8.14.8) with ESMTP id s93IfD6T020357;\r
+       Fri, 3 Oct 2014 11:41:14 -0700\r
+Received: (from imain@localhost)\r
+       by ovo.mains.priv (8.14.8/8.14.8/Submit) id s93IfCT9020356;\r
+       Fri, 3 Oct 2014 11:41:12 -0700\r
+X-Authentication-Warning: ovo.mains.priv: imain set sender to imain@redhat.com\r
+       using -f\r
+Date: Fri, 03 Oct 2014 11:41:12 -0700\r
+From: Ian Main <imain@stemwinder.org>\r
+To: David Bremner <david@tethera.net>, David Bremner <david@tethera.net>,\r
+       notmuch@notmuchmail.org\r
+Message-ID: <542eedc8cb635_ed1ddfe8cd0@ovo.mains.priv.notmuch>\r
+In-Reply-To: <87r3ypr6cm.fsf@maritornes.cs.unb.ca>\r
+References: <1412286796-27479-1-git-send-email-imain@stemwinder.org>\r
+       <1412293635-31273-1-git-send-email-imain@stemwinder.org>\r
+       <87r3ypr6cm.fsf@maritornes.cs.unb.ca>\r
+Subject: Re: [PATCH v2] VIM: Use notmuch CLI for config\r
+Mime-Version: 1.0\r
+Content-Type: text/plain;\r
+ charset=utf-8\r
+Content-Transfer-Encoding: 7bit\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 03 Oct 2014 18:41:30 -0000\r
+\r
+David Bremner wrote:\r
+> Ian Main <imain@stemwinder.org> writes:\r
+> \r
+> > This patch switches from reading .notmuch-config directly to using\r
+> > the CLI the same way that emacs does it.  It actually uses less code\r
+> > and is probably less error prone.\r
+> >\r
+> >     Ian\r
+> \r
+> The general approach seems sane; it seems quite brittle to read the\r
+> config file directly. I notice there is not really any error handling;\r
+> OTOH, as far as I can read Ruby, there is not any in the previous\r
+> version either.  Technically, this does add a dependency of the vim\r
+> client on the CLI that did not exist before. Personally I don't find\r
+> this onerous (even notmuch-vim users need "notmuch new", except in\r
+> rather unusual circumstances.).\r
+> \r
+> I'd like feedback/testing from actual vim interface users before\r
+> merging.\r
+\r
+I am actually just following suit on what was already being done.\r
+The Vim client was already calling out to notmuch CLI for other things,\r
+eg:\r
+\r
+   system "notmuch show --format=mbox id:#{m.message_id} > #{mbox} && #{cmd}"\r
+\r
+Is used to save the email for display in another program.  Also with no\r
+error checking.  I think basically we are relying on rubys exception handling\r
+to display errors to the user.. not the best idea but it is functional.\r
+\r
+I could add a check for 'notmuch' binary.. especially there because loading\r
+the config is the first thing that is done on startup.\r
+\r
+    Ian\r