Re: [PATCH] emacs: Do not color non-matching authors by tag

diff --git a/89/320c8f1aa737c24f7191d404e9c16290e3cd65 b/89/320c8f1aa737c24f7191d404e9c16290e3cd65
new file mode 100644 (file)
index 0000000..a83d9c2
--- /dev/null
+++ b/89/320c8f1aa737c24f7191d404e9c16290e3cd65
@@ -0,0 +1,93 @@
+Return-Path: <sojkam1@fel.cvut.cz>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 5A4194196F2\r
+       for <notmuch@notmuchmail.org>; Fri,  5 Nov 2010 01:10:14 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.9\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5\r
+       tests=[BAYES_00=-1.9] autolearn=ham\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id SI+68Y01tfzS for <notmuch@notmuchmail.org>;\r
+       Fri,  5 Nov 2010 01:10:04 -0700 (PDT)\r
+Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36])\r
+       by olra.theworths.org (Postfix) with ESMTP id E594A4196F0\r
+       for <notmuch@notmuchmail.org>; Fri,  5 Nov 2010 01:10:03 -0700 (PDT)\r
+Received: from localhost (unknown [192.168.200.4])\r
+       by max.feld.cvut.cz (Postfix) with ESMTP id 3B69B19F338C;\r
+       Fri,  5 Nov 2010 09:10:02 +0100 (CET)\r
+X-Virus-Scanned: IMAP AMAVIS\r
+Received: from max.feld.cvut.cz ([192.168.200.1])\r
+       by localhost (styx.feld.cvut.cz [192.168.200.4]) (amavisd-new,\r
+       port 10044)\r
+       with ESMTP id jXwRh4altgjA; Fri,  5 Nov 2010 09:10:00 +0100 (CET)\r
+Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34])\r
+       by max.feld.cvut.cz (Postfix) with ESMTP id E2FF719F3362;\r
+       Fri,  5 Nov 2010 09:10:00 +0100 (CET)\r
+Received: from steelpick.2x.cz (note-sojka.felk.cvut.cz [147.32.86.30])\r
+       (Authenticated sender: sojkam1)\r
+       by imap.feld.cvut.cz (Postfix) with ESMTPSA id F18C6FA003;\r
+       Fri,  5 Nov 2010 09:10:00 +0100 (CET)\r
+Received: from wsh by steelpick.2x.cz with local (Exim 4.72)\r
+       (envelope-from <sojkam1@fel.cvut.cz>)\r
+       id 1PEHN2-0004Oz-JR; Fri, 05 Nov 2010 09:10:00 +0100\r
+From: Michal Sojka <sojkam1@fel.cvut.cz>\r
+To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: Do not color non-matching authors by tag\r
+In-Reply-To: <87zktp2lma.fsf@ut.hh.sledj.net>\r
+References: <1287726122-5643-1-git-send-email-sojkam1@fel.cvut.cz>\r
+       <878w1942i6.fsf@ut.hh.sledj.net> <87vd4djhy2.fsf@steelpick.2x.cz>\r
+       <87zktp2lma.fsf@ut.hh.sledj.net>\r
+User-Agent: Notmuch/0.4-29-g9b64b0f (http://notmuchmail.org) Emacs/23.2.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Fri, 05 Nov 2010 09:10:00 +0100\r
+Message-ID: <87mxpojinb.fsf@steelpick.2x.cz>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 05 Nov 2010 08:10:14 -0000\r
+\r
+On Thu, 04 Nov 2010, David Edmondson wrote:\r
+> On Thu, 04 Nov 2010 15:12:53 +0100, Michal Sojka <sojkam1@fel.cvut.cz> wrote:\r
+> > > Michal, was this addressed by the patch that Carl recently merged?\r
+> > > (Commit f99ad42da03afd638bfdfdea92d1cbdd3b510b8f in my copy of the\r
+> > > repository.)\r
+> > \r
+> > Unfortunately not. In your patch, the overlay changes the color/face of the\r
+> > whole line while my patch change the color/face of all parts of the line\r
+> > except for non-matching authors. With my patch non-matched autors were\r
+> \r
+> I understand now.\r
+\r
+> \r
+> This seems somewhat like a policy decision, though. If I indicate that I\r
+> want the foreground text for a particular line to be red, should the\r
+> formatting of non-matching authors override that?\r
+> \r
+> (My own approach has been to have `notmuch-search-line-faces' always\r
+> specify a background colour whereas\r
+> `notmuch-search-non-matching-authors' (or any of the columnar faces)\r
+> specify a foreground colour and/or slant.)\r
+\r
+And now I even understand your patch. That's exactly what I wanted.\r
+Nice. I thought that overlays change completely the face of the line,\r
+hiding any faces "under" the overlay. Now I see, that\r
+notmuch-search-line-faces faces are combined with what was there before.\r
+\r
+-Michal\r
+\r