Re: [PATCH v3] build: write VERSION file containing $(VERSION) string

diff --git a/a6/f45ecb17354213e1d9d5321154c104854eb27e b/a6/f45ecb17354213e1d9d5321154c104854eb27e
new file mode 100644 (file)
index 0000000..c0f6623
--- /dev/null
+++ b/a6/f45ecb17354213e1d9d5321154c104854eb27e
@@ -0,0 +1,82 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1B093431FBF\r
+       for <notmuch@notmuchmail.org>; Tue, 28 Jan 2014 03:13:26 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id slIproWt2nqB for <notmuch@notmuchmail.org>;\r
+       Tue, 28 Jan 2014 03:13:16 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 7EB15431FBD\r
+       for <notmuch@notmuchmail.org>; Tue, 28 Jan 2014 03:13:16 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 9BD52100051;\r
+       Tue, 28 Jan 2014 13:13:06 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v3] build: write VERSION file containing $(VERSION) string\r
+In-Reply-To: <87zjmgkgxm.fsf@zancas.localnet>\r
+References: <1390858998-9846-1-git-send-email-tomi.ollila@iki.fi>\r
+       <1390859290-10112-1-git-send-email-tomi.ollila@iki.fi>\r
+       <87zjmgkgxm.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.17+55~g4397960 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Tue, 28 Jan 2014 13:13:06 +0200\r
+Message-ID: <m261p4mkal.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 28 Jan 2014 11:13:26 -0000\r
+\r
+On Tue, Jan 28 2014, David Bremner <david@tethera.net> wrote:\r
+\r
+> Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+>\r
+>> +VERSION:=$(shell gv=`exec git describe --match '[0-9.]*'|sed -e s/_/~/ -e s/-/+/ -e s/-/~/`; test -f VERSION || touch VERSION; read fv < VERSION; test x"$$fv" = x"$$gv" || echo "$$gv" > VERSION; echo "$$gv")\r
+>\r
+> does this need to be one line long? It's a bit scary.\r
+\r
+Probably not -- I realized after sending v3 I could have split that\r
+(among one other problem...)\r
+\r
+>\r
+>> +# this file may already have been updated.\r
+>> +VERSION: version\r
+>> +   echo $(VERSION) > version\r
+>\r
+> I'd prefer the build process does not change any version controlled\r
+> file. It should be source, or generated, but not both. did  you mean to\r
+> write to VERSION here?\r
+\r
+I sure meant to. actually echo $(VERSION) > $@\r
+\r
+>\r
+> d\r
+>\r
+\r
+Tnx for the review...\r
+\r
+\r
+Tomi\r