Re: [PATCH 1/3] emacs: Introduce `notmuch-call-notmuch-sexp'

diff --git a/a1/295a7c3fa2b596b30a7807f04598c11146bde9 b/a1/295a7c3fa2b596b30a7807f04598c11146bde9
new file mode 100644 (file)
index 0000000..4ebabb6
--- /dev/null
+++ b/a1/295a7c3fa2b596b30a7807f04598c11146bde9
@@ -0,0 +1,138 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 127DD431FB6\r
+       for <notmuch@notmuchmail.org>; Mon, 24 Jun 2013 12:29:47 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id go8QDVC32lye for <notmuch@notmuchmail.org>;\r
+       Mon, 24 Jun 2013 12:29:39 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id EDA6A431FAF\r
+       for <notmuch@notmuchmail.org>; Mon, 24 Jun 2013 12:29:38 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1UrCSH-00024D-6O; Mon, 24 Jun 2013 20:29:37 +0100\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1UrCSG-0005M3-T4; Mon, 24 Jun 2013 20:29:37 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Austin Clements <amdragon@MIT.EDU>\r
+Subject: Re: [PATCH 1/3] emacs: Introduce `notmuch-call-notmuch-sexp'\r
+In-Reply-To: <20130624191115.GB2214@mit.edu>\r
+References: <1372030999-1262-1-git-send-email-amdragon@mit.edu>\r
+       <87zjuftjuc.fsf@qmul.ac.uk> <20130624191115.GB2214@mit.edu>\r
+User-Agent: Notmuch/0.15.2+171~ge2f30a2 (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Mon, 24 Jun 2013 20:29:35 +0100\r
+Message-ID: <87sj07tihs.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: 04fc758cdd527537c2a7291ded30bff4 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -0.0\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored -0.0 points.\r
+       Summary of the scoring: \r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       * -0.0 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 24 Jun 2013 19:29:47 -0000\r
+\r
+\r
+That is fine.\r
+\r
+(I think I only moved your code from one file to another but in any case\r
+what you suggest is fine.)\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+On Mon, 24 Jun 2013, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> Yes, and thanks for reminding me about the require's.  I'll do that in\r
+> a follow up.  I was thinking of just moving the streaming JSON parser\r
+> to a repo on my GitHub account, since maybe somebody some day will\r
+> find a use for it, or at least take inspiration from the API (I looked\r
+> into streaming JSON parser APIs before embarking on that one and\r
+> they're all terrible!)  Mark, you're the only other person who has\r
+> touched that code.  Is this plan good with you?\r
+>\r
+> Quoth Mark Walters on Jun 24 at  8:00 pm:\r
+>> \r
+>> This series looks good to me +1. \r
+>> \r
+>> Is it worth removing all the json (3 files with (require 'json) and the\r
+>> async json parser) too?\r
+>> \r
+>> Best wishes\r
+>> \r
+>> Mark\r
+>> \r
+>> On Mon, 24 Jun 2013, Austin Clements <amdragon@MIT.EDU> wrote:\r
+>> > This is just like `notmuch-call-notmuch-json', but parses S-expression\r
+>> > output.  Note that, also like `notmuch-call-notmuch-json', this\r
+>> > doesn't consider trailing data to be an error, which may or may not be\r
+>> > what we want in the long run.\r
+>> > ---\r
+>> >  emacs/notmuch-lib.el |   17 +++++++++++++++++\r
+>> >  1 file changed, 17 insertions(+)\r
+>> >\r
+>> > diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el\r
+>> > index 534f217..36eacc1 100644\r
+>> > --- a/emacs/notmuch-lib.el\r
+>> > +++ b/emacs/notmuch-lib.el\r
+>> > @@ -484,6 +484,23 @@ an error."\r
+>> >         (json-read)))\r
+>> >   (delete-file err-file)))))\r
+>> >  \r
+>> > +(defun notmuch-call-notmuch-sexp (&rest args)\r
+>> > +  "Invoke `notmuch-command' with ARGS and return the parsed S-exp output.\r
+>> > +\r
+>> > +If notmuch exits with a non-zero status, this will pop up a\r
+>> > +buffer containing notmuch's output and signal an error."\r
+>> > +\r
+>> > +  (with-temp-buffer\r
+>> > +    (let ((err-file (make-temp-file "nmerr")))\r
+>> > +      (unwind-protect\r
+>> > +   (let ((status (apply #'call-process\r
+>> > +                        notmuch-command nil (list t err-file) nil args)))\r
+>> > +     (notmuch-check-exit-status status (cons notmuch-command args)\r
+>> > +                                (buffer-string) err-file)\r
+>> > +     (goto-char (point-min))\r
+>> > +     (read (current-buffer)))\r
+>> > + (delete-file err-file)))))\r
+>> > +\r
+>> >  (defun notmuch-start-notmuch (name buffer sentinel &rest args)\r
+>> >    "Start and return an asynchronous notmuch command.\r