Re: [PATCH] Avoid empty thread names if possible.

diff --git a/31/cbd163e1db2b589a085f022efbf18c94d7b277 b/31/cbd163e1db2b589a085f022efbf18c94d7b277
new file mode 100644 (file)
index 0000000..a419380
--- /dev/null
+++ b/31/cbd163e1db2b589a085f022efbf18c94d7b277
@@ -0,0 +1,113 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id F3452431FBF\r
+       for <notmuch@notmuchmail.org>; Tue, 28 Oct 2014 14:37:20 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 5EL5BjWDSZRZ for <notmuch@notmuchmail.org>;\r
+       Tue, 28 Oct 2014 14:37:12 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8CECC431FB6\r
+       for <notmuch@notmuchmail.org>; Tue, 28 Oct 2014 14:37:12 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 4B3B6100051;\r
+       Tue, 28 Oct 2014 23:36:58 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Jesse Rosenthal <jrosenthal@jhu.edu>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] Avoid empty thread names if possible.\r
+In-Reply-To: <87oatnakqy.fsf@jhu.edu>\r
+References: <87oatnakqy.fsf@jhu.edu>\r
+User-Agent: Notmuch/0.18.1+130~ga61922f (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Tue, 28 Oct 2014 23:36:58 +0200\r
+Message-ID: <m2fve7dgg5.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 28 Oct 2014 21:37:21 -0000\r
+\r
+On Tue, Oct 07 2014, Jesse Rosenthal wrote:\r
+\r
+> Currently the thread is named based on either the oldest or newest\r
+> matching message (depending on the search order). If this message has\r
+> an empty subject, though, the thread will show up with an empty\r
+> subject in the search results. (See the thread starting with\r
+> `id:1412371140-21051-1-git-send-email-david@tethera.net` for an\r
+> example.)\r
+>\r
+> This patch changes the behavior to name based on the oldest/newest\r
+> matching non-empty subject. This is particularly helpful for patchsets.\r
+> If the only subjects are empty, the thread subject will still be empty.\r
+>\r
+> Signed-off-by: Jesse Rosenthal <jrosenthal@jhu.edu>\r
+> ---\r
+>  lib/thread.cc | 6 ++++--\r
+>  1 file changed, 4 insertions(+), 2 deletions(-)\r
+>\r
+> diff --git a/lib/thread.cc b/lib/thread.cc\r
+> index 8922403..ea10295 100644\r
+> --- a/lib/thread.cc\r
+> +++ b/lib/thread.cc\r
+> @@ -348,18 +348,20 @@ _thread_add_matched_message (notmuch_thread_t *thread,\r
+>  {\r
+>      time_t date;\r
+>      notmuch_message_t *hashed_message;\r
+> +    const char *cur_subject;\r
+>  \r
+>      date = notmuch_message_get_date (message);\r
+> +    cur_subject = notmuch_thread_get_subject (thread);\r
+>  \r
+>      if (date < thread->oldest || ! thread->matched_messages) {\r
+>      thread->oldest = date;\r
+> -    if (sort == NOTMUCH_SORT_OLDEST_FIRST)\r
+> +    if (sort == NOTMUCH_SORT_OLDEST_FIRST || strlen(cur_subject) == 0)\r
+\r
+IMO it is a bit silly to scan through the whole string and use the return\r
+value of 0 (vs != 0) to have effect. we should probably have something like\r
+#define EMPTY_STRING(s) ((s)[0] == '\0') \r
+and use that instead.\r
+\r
+Also, to keep promise, mentioning 'patch' in commit message referring to \r
+the change introduced does IMO also look silly :D\r
+\r
+Tomi\r
+\r
+>          _thread_set_subject_from_message (thread, message);\r
+>      }\r
+>  \r
+>      if (date > thread->newest || ! thread->matched_messages) {\r
+>      thread->newest = date;\r
+> -    if (sort != NOTMUCH_SORT_OLDEST_FIRST)\r
+> +    if (sort != NOTMUCH_SORT_OLDEST_FIRST || strlen(cur_subject) == 0)\r
+>          _thread_set_subject_from_message (thread, message);\r
+>      }\r
+>  \r
+> -- \r
+> 2.1.2\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r