Re: privacy problem: text/html parts pull in network resources

diff --git a/4f/6837a5898f45fbd45bf79f813c00510ec16c36 b/4f/6837a5898f45fbd45bf79f813c00510ec16c36
new file mode 100644 (file)
index 0000000..a129eb7
--- /dev/null
+++ b/4f/6837a5898f45fbd45bf79f813c00510ec16c36
@@ -0,0 +1,100 @@
+Return-Path: <aclements@csail.mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id CFB00431FC9\r
+       for <notmuch@notmuchmail.org>; Wed, 21 Jan 2015 14:39:13 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.138\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.138 tagged_above=-999 required=5\r
+       tests=[DNS_FROM_AHBL_RHSBL=2.438, RCVD_IN_DNSWL_MED=-2.3]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id vRvldbayjeuK for <notmuch@notmuchmail.org>;\r
+       Wed, 21 Jan 2015 14:39:10 -0800 (PST)\r
+Received: from outgoing.csail.mit.edu (outgoing.csail.mit.edu [128.30.2.149])\r
+       by olra.theworths.org (Postfix) with ESMTP id 9ADEE431FBC\r
+       for <notmuch@notmuchmail.org>; Wed, 21 Jan 2015 14:39:10 -0800 (PST)\r
+Received: from [104.131.20.129] (helo=awakeningjr)\r
+       by outgoing.csail.mit.edu with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16)\r
+       (Exim 4.72) (envelope-from <aclements@csail.mit.edu>)\r
+       id 1YE3vZ-0002TM-KD; Wed, 21 Jan 2015 17:39:09 -0500\r
+Received: from amthrax by awakeningjr with local (Exim 4.84)\r
+       (envelope-from <aclements@csail.mit.edu>)\r
+       id 1YE3vZ-0001pR-4A; Wed, 21 Jan 2015 17:39:09 -0500\r
+Date: Wed, 21 Jan 2015 17:39:09 -0500\r
+From: Austin Clements <aclements@csail.mit.edu>\r
+To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>\r
+Subject: Re: privacy problem: text/html parts pull in network resources\r
+Message-ID: <20150121223909.GL22599@csail.mit.edu>\r
+References: <87ppa7q25w.fsf@alice.fifthhorseman.net>\r
+       <20150121211407.GK22599@csail.mit.edu>\r
+       <87k30fq0hx.fsf@alice.fifthhorseman.net>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <87k30fq0hx.fsf@alice.fifthhorseman.net>\r
+User-Agent: Mutt/1.5.23 (2014-03-12)\r
+Cc: notmuch mailing list <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 21 Jan 2015 22:39:14 -0000\r
+\r
+Quoth Daniel Kahn Gillmor on Jan 21 at  4:36 pm:\r
+> On Wed 2015-01-21 16:14:07 -0500, Austin Clements wrote:\r
+> > I have a fix for this on shr buried deep in an old patch series that I\r
+> > never got back to: id:1398105468-14317-12-git-send-email-amdragon@mit.edu\r
+> >\r
+> > For shr, the key is to set shr-blocked-images to ".".\r
+> \r
+> I've just done this, but it doesn't seem to help.\r
+> \r
+> > However, IIRC, in the current notmuch message rendering pipeline, mm\r
+> > overrides this variable with something computed from\r
+> > gnus-blocked-images.  That said, I'm not sure why gnus-blocked-images\r
+> > isn't *already* taking care of this, but that's probably the place to\r
+> > start digging.\r
+> \r
+> gnus-blocked-images is set for me to the function\r
+> gnus-block-private-groups, but i don't know what that is (the function\r
+> is undocumented afaict).  Setting gnus-blocked-images to a regexp of "."\r
+> seems to work for me, though.\r
+\r
+In notmuch, mm will wind up calling (gnus-block-private-groups nil).\r
+Unfortunately, gnus apparently considers nil to be a news group rather\r
+than a "private group" (gnus speak for email, I think), so\r
+gnus-block-private-groups returns nil (meaning *don't* block images)\r
+rather than ".".\r
+\r
+Probably notmuch should override the gnus-blocked-images variable,\r
+since the default value is simply wrong for notmuch.  Maybe something\r
+along the lines of the following should go around our text/html\r
+handler?\r
+\r
+  (let ((gnus-blocked-images\r
+         (if (eq gnus-blocked-images 'gnus-block-private-groups)\r
+             ;; mm uses gnus-blocked-images to control image loading.\r
+             ;; However, the default value of gnus-blocked-images\r
+             ;; doesn't work for notmuch because\r
+             ;; gnus-block-private-groups depends on gnus variables we\r
+             ;; don't set.  Override it to disallow network image\r
+             ;; loading.\r
+             "."\r
+           ;; Use the user's customized value.\r
+           gnus-blocked-images)))\r
+    ...)\r
+\r
+Long live abstraction!\r