Re: [Patch v6 1/6] tag-util: factor out rules for illegal tags, use in parse_tag_line

diff --git a/b5/c94bd1fdf59da62a4dc394a9d7bfa8c445fa37 b/b5/c94bd1fdf59da62a4dc394a9d7bfa8c445fa37
new file mode 100644 (file)
index 0000000..656b267
--- /dev/null
+++ b/b5/c94bd1fdf59da62a4dc394a9d7bfa8c445fa37
@@ -0,0 +1,72 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id EEB5C431FC2\r
+       for <notmuch@notmuchmail.org>; Sat, 15 Dec 2012 04:39:28 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id dviBaxaHyPDp for <notmuch@notmuchmail.org>;\r
+       Sat, 15 Dec 2012 04:39:28 -0800 (PST)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 86B87431FBF\r
+       for <notmuch@notmuchmail.org>; Sat, 15 Dec 2012 04:39:28 -0800 (PST)\r
+Received: from fctnnbsc30w-142167090129.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([142.167.90.129] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1Tjr1Y-0006Bb-OQ; Sat, 15 Dec 2012 08:39:24 -0400\r
+Received: from bremner by zancas.localnet with local (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1Tjr1T-0008TU-54; Sat, 15 Dec 2012 08:39:19 -0400\r
+From: David Bremner <david@tethera.net>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [Patch v6 1/6] tag-util: factor out rules for illegal tags,\r
+       use in parse_tag_line\r
+In-Reply-To: <871uettxln.fsf@qmul.ac.uk>\r
+References: <1355096008-4544-1-git-send-email-david@tethera.net>\r
+       <1355096008-4544-2-git-send-email-david@tethera.net>\r
+       <871uettxln.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.14+163~g11a220a (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 15 Dec 2012 08:39:19 -0400\r
+Message-ID: <87vcc35w20.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 15 Dec 2012 12:39:29 -0000\r
+\r
+Mark Walters <markwalters1009@gmail.com> writes:\r
+\r
+> I don't know if this matters but it seems that one can still add a "-"\r
+> tag by doing something like\r
+>\r
+> echo "+%2d -- search" | notmuch tag --batch\r
+>\r
+> This might be the right thing to do but I thought I would mention it.\r
+\r
+I _think_ it's a feature, so I'm tempted to document it and move on\r
+unless somebody convinces me it's a bad idea.\r
+\r
+d\r