Re: [PATCH 1/2] cli: clean up exit status code returned by the cli commands

diff --git a/b6/93e7f9642c7189d5727cf44045bdcddf6de765 b/b6/93e7f9642c7189d5727cf44045bdcddf6de765
new file mode 100644 (file)
index 0000000..5733131
--- /dev/null
+++ b/b6/93e7f9642c7189d5727cf44045bdcddf6de765
@@ -0,0 +1,110 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1AA72431FBD\r
+       for <notmuch@notmuchmail.org>; Sat, 18 Jan 2014 05:09:32 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id VVOWNWp3uIgB for <notmuch@notmuchmail.org>;\r
+       Sat, 18 Jan 2014 05:09:24 -0800 (PST)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id DDCE3431FBC\r
+       for <notmuch@notmuchmail.org>; Sat, 18 Jan 2014 05:09:23 -0800 (PST)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1W4VeL-0007Dy-8G; Sat, 18 Jan 2014 13:09:21 +0000\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1W4VeK-0002fd-SH; Sat, 18 Jan 2014 13:09:21 +0000\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, Jani Nikula <jani@nikula.org>,\r
+       notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/2] cli: clean up exit status code returned by the cli\r
+       commands\r
+In-Reply-To: <m28uumyg03.fsf@guru.guru-group.fi>\r
+References: <1389389334-24138-1-git-send-email-jani@nikula.org>\r
+       <m28uumyg03.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.15.2+484~gfb59956 (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 18 Jan 2014 13:09:19 +0000\r
+Message-ID: <87ob39cu80.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-Geographic: According to ripencc,\r
+       this message was delivered by a machine in Britain (UK) (GB).\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: 761b087ee2e9a62d8b74b8b5a5e6faaa (of first 20000 bytes)\r
+X-SpamAssassin-Score: 0.0\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored 0.0 points. Summary of the scoring: \r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       *  0.0 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 18 Jan 2014 13:09:32 -0000\r
+\r
+\r
+These LGTM too.\r
+\r
+Best wishes \r
+\r
+Mark\r
+\r
+On Sat, 11 Jan 2014, Tomi Ollila <tomi.ollila@iki.fi> wrote:\r
+> On Fri, Jan 10 2014, Jani Nikula <jani@nikula.org> wrote:\r
+>\r
+>> Apart from the status codes for format mismatches, the non-zero exit\r
+>> status codes have been arbitrary. Make the cli consistently return\r
+>> either EXIT_SUCCESS or EXIT_FAILURE.\r
+>> ---\r
+>\r
+> These 2 patches LGTM.\r
+>\r
+> Tomi\r
+>\r
+>\r
+>>  notmuch-compact.c |  6 +++---\r
+>>  notmuch-config.c  | 23 ++++++++++++++---------\r
+>>  notmuch-count.c   | 16 +++++++---------\r
+>>  notmuch-dump.c    | 21 +++++++++------------\r
+>>  notmuch-insert.c  | 25 +++++++++++--------------\r
+>>  notmuch-new.c     | 18 ++++++++----------\r
+>>  notmuch-reply.c   | 20 +++++++++-----------\r
+>>  notmuch-restore.c | 23 +++++++++--------------\r
+>>  notmuch-search.c  | 18 ++++++++----------\r
+>>  notmuch-setup.c   | 15 +++++++--------\r
+>>  notmuch-show.c    | 18 ++++++++----------\r
+>>  notmuch-tag.c     | 22 +++++++++++-----------\r
+>>  notmuch.c         | 43 ++++++++++++++++++++++++++++---------------\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r