Prior to commit a141d715, CMD_NOINSTALL had no default set, but most of the usages...

Signed-off-by: Robin H. Johnson <robbat2@orbis-terrarum.net>

diff --git a/ChangeLog b/ChangeLog
index 8b3c23e4f0cc79625edd6030c8d5c4287e57083b..e1a5545f285b7a36cadcecc6b7877e8ce0e74e96 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -5,6 +5,13 @@
 # Distributed under the GPL v2
 # $Id$
 
+  13 Jan 2012; Robin H. Johnson <robbat2@gentoo.org> gen_determineargs.sh:
+  Prior to commit a141d715, CMD_NOINSTALL had no default set, but most of the
+  usages were of the form "! isTrue ${CMD_NOINSTALL}", which on an unset value,
+  came out as false. These were replaced by "isTrue ${CMD_INSTALL}", but my
+  analysis of the needed default value was wrong, and was set to false instead
+  of true.
+
   13 Jan 2012; Sebastian Pipping <sping@gentoo.org> genkernel.conf:
   Replace "# FOO=bar" by "#FOO=bar" in genkernel.conf to (1) distinguish
   commented-out options from their explanatory comments and (2) to return

diff --git a/gen_determineargs.sh b/gen_determineargs.sh
index cd91a27d2ab7facc4077e4224c715e5602de42fd..66f7ee1aaf1c23eeda87c49a673647f37e8b07bb 100755 (executable)
--- a/gen_determineargs.sh
+++ b/gen_determineargs.sh
@@ -128,7 +128,7 @@ determine_real_args() {
        set_config_with_override BOOL   KEYMAP               CMD_KEYMAP               "yes"
        set_config_with_override BOOL   DOKEYMAPAUTO         CMD_DOKEYMAPAUTO
        set_config_with_override STRING BUSYBOX_CONFIG       CMD_BUSYBOX_CONFIG
-       set_config_with_override BOOL   INSTALL              CMD_INSTALL              "no"
+       set_config_with_override BOOL   INSTALL              CMD_INSTALL              "yes"
 
        BOOTDIR=`arch_replace "${BOOTDIR}"`
        BOOTDIR=${BOOTDIR%/}    # Remove any trailing slash