--- /dev/null
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id D5026429E59\r
+ for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 15:33:19 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+ tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+ FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id PG+dAagO9Dng for <notmuch@notmuchmail.org>;\r
+ Sun, 29 Jan 2012 15:33:19 -0800 (PST)\r
+Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com\r
+ [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 29310429E57\r
+ for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 15:33:19 -0800 (PST)\r
+Received: by bke11 with SMTP id 11so879856bke.26\r
+ for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 15:33:17 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+ h=from:to:cc:subject:in-reply-to:references:user-agent:date\r
+ :message-id:mime-version:content-type;\r
+ bh=Fe17iqW0y2aEERUpxobb1Lc7vZVmJ5BjAJAVZb4skUA=;\r
+ b=Hn15JP6LDAEzI208k1vfd9Yf44lnSL9Gt5dMAopWvsMPlSVMUhgg1tCRWW6pBVc/nE\r
+ 0LWIjndSjgbhkVjEO4wzvstlcZ/X1iZ/qcopzY5GW7cyrVVoQr+7iDg5d1r30PPXUgg5\r
+ MXYbkT7954zm9beNOZVV1NXTl0zSGNASSURpg=\r
+Received: by 10.205.135.146 with SMTP id ig18mr7254203bkc.73.1327879997797;\r
+ Sun, 29 Jan 2012 15:33:17 -0800 (PST)\r
+Received: from localhost ([91.144.186.21])\r
+ by mx.google.com with ESMTPS id ga13sm33453292bkc.5.2012.01.29.15.33.16\r
+ (version=TLSv1/SSLv3 cipher=OTHER);\r
+ Sun, 29 Jan 2012 15:33:17 -0800 (PST)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: Austin Clements <amdragon@MIT.EDU>\r
+Subject: Re: [PATCH 1/6] emacs: move tag format validation to `notmuch-tag'\r
+ function\r
+In-Reply-To: <20120129231650.GK17991@mit.edu>\r
+References: <1327725684-5887-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+ <20120129213427.GF17991@mit.edu> <87fwey86hj.fsf@gmail.com>\r
+ <20120129231650.GK17991@mit.edu>\r
+User-Agent: Notmuch/0.11+134~g7ddba9d (http://notmuchmail.org) Emacs/23.3.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Mon, 30 Jan 2012 03:32:08 +0400\r
+Message-ID: <878vkq84qv.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 29 Jan 2012 23:33:20 -0000\r
+\r
+On Sun, 29 Jan 2012 18:16:50 -0500, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> Quoth Dmitry Kurochkin on Jan 30 at 2:54 am:\r
+> > Hi Austin.\r
+> > \r
+> > On Sun, 29 Jan 2012 16:34:27 -0500, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> > > One philosophical nit below, but not enough to hold this up.\r
+> > > \r
+> > > Quoth Dmitry Kurochkin on Jan 28 at 8:41 am:\r
+> > > > Before the change, tag format validation was done in\r
+> > > > `notmuch-search-operate-all' function only. The patch moves it down\r
+> > > > to `notmuch-tag', so that all users of that function get input\r
+> > > > validation.\r
+> > > > ---\r
+> > > > emacs/notmuch.el | 12 ++++++------\r
+> > > > 1 files changed, 6 insertions(+), 6 deletions(-)\r
+> > > > \r
+> > > > diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+> > > > index 72f78ed..84d7d0a 100644\r
+> > > > --- a/emacs/notmuch.el\r
+> > > > +++ b/emacs/notmuch.el\r
+> > > > @@ -522,6 +522,12 @@ Note: Other code should always use this function alter tags of\r
+> > > > messages instead of running (notmuch-call-notmuch-process \"tag\" ..)\r
+> > > > directly, so that hooks specified in notmuch-before-tag-hook and\r
+> > > > notmuch-after-tag-hook will be run."\r
+> > > > + ;; Perform some validation\r
+> > > > + (when (null tags) (error "No tags given"))\r
+> > > \r
+> > > Since this is a non-interactive function and hence is meant to be\r
+> > > invoked programmatically, I would expect it to accept zero tags.\r
+> > > Unlike the following check, this is a UI-level check and thus, I\r
+> > > believe, belongs in interactive functions (even if that requires a\r
+> > > little duplication).\r
+> > > \r
+> > \r
+> > Agreed. Though I would hate to add the same check to each tag\r
+> > operation. Perhaps this check can go to\r
+> > `notmuch-select-tags-with-completion'?\r
+> > \r
+> > This is not the main patch in the series. So I think I would prefer not\r
+> > to make v2 because of this issue. If we come up with a good (i.e. no\r
+> > duplication) solution, I will prepare a separate patch for it.\r
+> \r
+> What about not giving any error for no tags? As a user, if I delete\r
+> the whole tags prompt including the +/- operator, that's a very\r
+> explicit action and it's very clear what it should do (nothing). I\r
+> don't need Emacs wagging its finger at me for doing something with a\r
+> clear meaning.\r
+\r
+Sure, let's try it.\r
+\r
+I am always hesitant to do changes like this to avoid boring discussions\r
+on what is better. I hope nobody would argue with this change :)\r
+\r
+Regards,\r
+ Dmitry\r
projects / notmuch-archives.git / commitdiff