--- /dev/null
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 20535431FB6\r
+ for <notmuch@notmuchmail.org>; Tue, 4 Sep 2012 23:48:57 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+ autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id JM7ZX-MH-Lqw for <notmuch@notmuchmail.org>;\r
+ Tue, 4 Sep 2012 23:48:52 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by olra.theworths.org (Postfix) with ESMTP id C03DE431FAF\r
+ for <notmuch@notmuchmail.org>; Tue, 4 Sep 2012 23:48:52 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id CEF601000E5;\r
+ Wed, 5 Sep 2012 09:48:58 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: Add customization group for replying\r
+In-Reply-To: <87zk55n44x.fsf@steelpick.2x.cz>\r
+References: <1343311113-22171-1-git-send-email-sojkam1@fel.cvut.cz>\r
+ <87vcfu2qap.fsf@steelpick.2x.cz>\r
+ <m2ligqnoap.fsf@guru.guru-group.fi>\r
+ <87zk55n44x.fsf@steelpick.2x.cz>\r
+User-Agent: Notmuch/0.14+11~gd9bf007 (http://notmuchmail.org) Emacs/24.2.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 05 Sep 2012 09:48:58 +0300\r
+Message-ID: <m21uih6k2t.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 05 Sep 2012 06:48:57 -0000\r
+\r
+On Tue, Sep 04 2012, Michal Sojka <sojkam1@fel.cvut.cz> wrote:\r
+\r
+> On Tue, Sep 04 2012, Tomi Ollila wrote:\r
+>> On Tue, Sep 04 2012, Michal Sojka <sojkam1@fel.cvut.cz> wrote:\r
+>>\r
+>>> On Thu, Jul 26 2012, Michal Sojka wrote:\r
+>>>> When one wants to customize the format of reply message, there nothing\r
+>>>> to tell the user how to do it. Without knowing that construction of\r
+>>>> reply buffer is actually implemented in the message package, it seems\r
+>>>> that replying cannot be customized.\r
+>>>>\r
+>>>> Because I was getting annoyed by the empty line the between citation\r
+>>>> line and the quoted message, I figured out that changing this is fairly\r
+>>>> easy when one knows what to customize.\r
+>>>>\r
+>>>> This patch adds notmuch-reply customization group that that contains\r
+>>>> references to the relevant customization options. The new group is easy\r
+>>>> to find as it is shown as a result of running "M-x customize-group RET\r
+>>>> notmuch RET".\r
+>>>\r
+>>> Ping.\r
+>>>\r
+>>> Any objections against applying?\r
+>>\r
+>> Nobody dares to say anything due to infamiliriaty of this spesific case ;/.\r
+>>\r
+>> I could not find any reference this has been made before.\r
+>\r
+> It's at least documented at\r
+> http://www.gnu.org/software/emacs/manual/html_node/elisp/Group-Definitions.html\r
+>\r
+> The argument members is a list specifying an initial set of\r
+> customization items to be members of the group. However, most often\r
+> members is nil, and you specify the group's members by using the\r
+> :group keyword when defining those members.\r
+>\r
+>> I could not find any discussion about this issue.\r
+>>\r
+>> With little effort I could not extract the customization tree to\r
+>> stdout I could have attempted to grep whether there is same variable\r
+>> in many groups.\r
+>\r
+> I tried to grep emacs sources and found the following:\r
+>\r
+> (defgroup message '((user-mail-address custom-variable)\r
+> (defgroup gnus-message '((message custom-group))\r
+> (defgroup ps-print-printer '((lpr custom-group))\r
+> (defgroup customize '((widgets custom-group))\r
+> (defgroup font-lock '((jit-lock custom-group))\r
+>\r
+> At least the first line corresponds exactly to what is proposed in my\r
+> patch.\r
+\r
+Yes...\r
+\r
+\r
+I was looking whether the same customization variable has been put\r
+into multiple groups (now those are also in message-insertion group like\r
+you have in your patch). (So far) I haven't seen that to be done\r
+(not that it forbids doing so, just that there aren't issues about that).\r
+\r
+>From consistency point of view all the customization variables in notmuch\r
+groups start with "notmuch-" and these "message-" breaks this... An\r
+alternative to the above could be the following:\r
+\r
+ (defgroup notmuch-reply\r
+ '((notmuch-message-replied-tags custom-variable)\r
+ (message-insertion custom-group))\r
+ "..."\r
+\r
+I.e. first moving notmuch-message-replied-tags to this new group\r
+and (only) referencing the message-insertion group from notmuch-reply\r
+group (the message-citation-line-format & message-citation-line-function\r
+are the first variables in message-insertion group, which is nice).\r
+\r
+\r
+> Cheers,\r
+> -Michal\r
+\r
+Tomi\r
projects / notmuch-archives.git / commitdiff