Re: [PATCH] emacs: bugfix unquoted symbol

diff --git a/0a/791fd1c4b819343ece34d463c2a8eec68ecf3f b/0a/791fd1c4b819343ece34d463c2a8eec68ecf3f
new file mode 100644 (file)
index 0000000..14c92b4
--- /dev/null
+++ b/0a/791fd1c4b819343ece34d463c2a8eec68ecf3f
@@ -0,0 +1,112 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id EA24C431FAF\r
+       for <notmuch@notmuchmail.org>; Sat, 14 Sep 2013 13:55:21 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id HUUMRY-koCdn for <notmuch@notmuchmail.org>;\r
+       Sat, 14 Sep 2013 13:55:15 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-4.mit.edu (dmz-mailsec-scanner-4.mit.edu\r
+       [18.9.25.15])\r
+       by olra.theworths.org (Postfix) with ESMTP id 9D521431FAE\r
+       for <notmuch@notmuchmail.org>; Sat, 14 Sep 2013 13:55:15 -0700 (PDT)\r
+X-AuditID: 1209190f-b7fa58e000000953-34-5234cd32026e\r
+Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])\r
+       by dmz-mailsec-scanner-4.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id EC.DC.02387.23DC4325; Sat, 14 Sep 2013 16:55:14 -0400 (EDT)\r
+Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\r
+       by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id r8EKtDt4008066; \r
+       Sat, 14 Sep 2013 16:55:14 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r8EKtBdZ016354\r
+       (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
+       Sat, 14 Sep 2013 16:55:12 -0400\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1VKws1-0003ht-RY; Sat, 14 Sep 2013 16:55:10 -0400\r
+Date: Sat, 14 Sep 2013 16:55:09 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Mark Walters <markwalters1009@gmail.com>\r
+Subject: Re: [PATCH] emacs: bugfix unquoted symbol\r
+Message-ID: <20130914205508.GW1426@mit.edu>\r
+References: <1379189827-21363-1-git-send-email-markwalters1009@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <1379189827-21363-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFmpkleLIzCtJLcpLzFFi42IRYrdT1zU6axJk8Kvf2GL1XB6L6zdnMjsw\r
+       eeycdZfd49mqW8wBTFFcNimpOZllqUX6dglcGbP7jrIUTOKs2HSpg6mBcRp7FyMHh4SAicTh\r
+       bzZdjJxAppjEhXvr2UBsIYF9jBJ3dxt3MXIB2RsZJWa9O80G4ZxmkljdeIkdwlnCKHFrwU1W\r
+       kBYWAVWJSz8esoPYbAIaEtv2L2cEsUUEdCRuH1oAFmcWkJb49ruZCcQWFjCS2LxtGVicV0Bb\r
+       4syHo8wQqz0luk69YIWIC0qcnPmEBaJXS+LGv5dMIFeDzFn+jwMkzCngJdH7pA/salEBFYkp\r
+       J7exTWAUmoWkexaS7lkI3QsYmVcxyqbkVunmJmbmFKcm6xYnJ+blpRbpmujlZpbopaaUbmIE\r
+       hTSnJP8Oxm8HlQ4xCnAwKvHwfvA1DhJiTSwrrsw9xCjJwaQkynvjtEmQEF9SfkplRmJxRnxR\r
+       aU5q8SFGCQ5mJRFeJzGgHG9KYmVValE+TEqag0VJnHe9k36QkEB6YklqdmpqQWoRTFaGg0NJ\r
+       glfiDFCjYFFqempFWmZOCUKaiYMTZDgP0HA7kBre4oLE3OLMdIj8KUZFKXFeGZCEAEgiozQP\r
+       rheWcl4xigO9IsxrA1LFA0xXcN2vgAYzAQ3evNsIZHBJIkJKqoGx6OZn3tVH5c67/Zv25tGM\r
+       xYbqF2ZqvtfsLak1eBDZFjDh6rvz1YfczhcXOHTpFMR7mwukb1b9t7f9+hKHqx8C3eqd3j+Q\r
+       zA++cCJhg06+uWRXH4/5uZY2i6BrZsu2xq7KLrlz4/Vh1ZK7sbn3XTk2pQkE3nwclGleFbWV\r
+       6d3nmYKxD764PA5RYinOSDTUYi4qTgQAFaWigBQDAAA=\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 14 Sep 2013 20:55:22 -0000\r
+\r
+Definitely LGTM.\r
+\r
+Quoth Mark Walters on Sep 14 at  9:17 pm:\r
+> In the recent changes for search order handling the default-value of\r
+> notmuch-search-oldest-first was used. However, default-value needs a\r
+> symbol so the symbol-name needs to be quoted.\r
+> \r
+> This missing quote was causing strange sort-orders in some cases.\r
+> ---\r
+> \r
+> I think this is clearly correct (and what was intended) and it seems\r
+> to work as expected.\r
+> \r
+> Best wishes\r
+> \r
+> Mark\r
+> \r
+> \r
+> \r
+> \r
+>  emacs/notmuch.el |    2 +-\r
+>  1 files changed, 1 insertions(+), 1 deletions(-)\r
+> \r
+> diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+> index 4de6229..0ff248b 100644\r
+> --- a/emacs/notmuch.el\r
+> +++ b/emacs/notmuch.el\r
+> @@ -888,7 +888,7 @@ the configured default sort order."\r
+>      nil\r
+>      ;; Use the default search order (if we're doing a search from a\r
+>      ;; search buffer, ignore any buffer-local overrides)\r
+> -    (default-value notmuch-search-oldest-first)))\r
+> +    (default-value 'notmuch-search-oldest-first)))\r
+>  \r
+>    (let* ((query (or query (notmuch-read-query "Notmuch search: ")))\r
+>       (buffer (get-buffer-create (notmuch-search-buffer-title query))))\r