Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el.

diff --git a/c0/a19f4cea692662536f87086b6a7b85c82ea369 b/c0/a19f4cea692662536f87086b6a7b85c82ea369
new file mode 100644 (file)
index 0000000..75484c0
--- /dev/null
+++ b/c0/a19f4cea692662536f87086b6a7b85c82ea369
@@ -0,0 +1,106 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1790B431FBC\r
+       for <notmuch@notmuchmail.org>; Tue,  8 Jul 2014 01:57:11 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id nXDehPoTKr87 for <notmuch@notmuchmail.org>;\r
+       Tue,  8 Jul 2014 01:57:02 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id BF414431FAF\r
+       for <notmuch@notmuchmail.org>; Tue,  8 Jul 2014 01:57:02 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 9504710008F;\r
+       Tue,  8 Jul 2014 11:56:55 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Sebastian Lipp <bacuh@riseup.net>, Karl Fogel <kfogel@red-bean.com>\r
+Subject: Re: [PATCH] emacs: add missing paren to fix defun\r
+       in      notmuch-address.el.\r
+In-Reply-To:\r
+ <87bnt2dy0b.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me>\r
+References: <87wqsfik5l.fsf@floss.red-bean.com>\r
+       <87mwtah2hd.fsf@zancas.localnet>\r
+       <877gkeau42.fsf@floss.red-bean.com>\r
+       <m2ppy5v3mc.fsf@guru.guru-group.fi> <8738v1jtzc.fsf@nikula.org>\r
+       <87k3odgutd.fsf@zancas.localnet> <87ip3wbj7g.fsf@mcs.anl.gov>\r
+       <m2hajgxli5.fsf@guru.guru-group.fi>\r
+       <87vc7vgbym.fsf@zancas.localnet>\r
+       <m2ehejykb1.fsf@guru.guru-group.fi>\r
+       <87pphmc604.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me>\r
+       <87oax6vt4u.fsf@ktab.red-bean.com>\r
+       <87bnt2dy0b.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me>\r
+User-Agent: Notmuch/0.18.1+25~gdaf4b6f (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Tue, 08 Jul 2014 11:56:55 +0300\r
+Message-ID: <m2ion844a0.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 08 Jul 2014 08:57:11 -0000\r
+\r
+On Sun, Jul 06 2014, Sebastian Lipp <bacuh@riseup.net> wrote:\r
+\r
+> Karl Fogel <kfogel@red-bean.com> writes:\r
+>> Sebastian Lipp <bacuh@riseup.net> writes:\r
+>>>diff --git a/emacs/notmuch-address.el b/emacs/notmuch-address.el\r
+>>>index fa65cd5..ee7b169 100644\r
+>>>--- a/emacs/notmuch-address.el\r
+>>>+++ b/emacs/notmuch-address.el\r
+>>>@@ -113,6 +113,59 @@ to know how address selection is made by default."\r
+>>> (when (notmuch-address-locate-command notmuch-address-command)\r
+>>>   (notmuch-address-message-insinuate))\r
+>>> \r
+>>>+;; functions to add sender / recipients to BBDB\r
+>>>+\r
+>>>+(defvar bbdb-get-addresses-headers)\r
+>>\r
+>> I think it's good to include an initial value (even an invalid\r
+>> placeholder one, if the real initialization has not happened yet), and a\r
+>> doc string.  C-h f defvar RET will say more about how to do that.\r
+>\r
+> I hope I got that right now. (I've got no real clue of Lisp yet because\r
+> I just recently switched to emacs partly because of notmuch. :)\r
+>\r
+> How about\r
+>\r
+>     (defvar bbdb-get-addresses-headers nil\r
+>       "List of Addresses to import into bbdb")\r
+>\r
+> ?\r
+>\r
+>> (By the way, this isn't a user-customizeable variable, right?  If it\r
+>> were, then `defcustom' would be better than `defvar'.)\r
+>\r
+> As far as I understand it: It's not.\r
+\r
+someone(tm) could explain why or why-not this is defvar and not defcustom\r
+(or wice versa) so that I don't have to spend time digging into it\r
+\r
+but the bbdb-* looks a bit too generic (goes deep into bbdb "namespace"\r
+in a file not part of bbdb -package)\r
+\r
+\r
+Tomi\r