Re: [PATCH] Rename already used counter var i

diff --git a/c4/6014f854e9dd715e38dd61d3bd50b905e5f5af b/c4/6014f854e9dd715e38dd61d3bd50b905e5f5af
new file mode 100644 (file)
index 0000000..edc9d5b
--- /dev/null
+++ b/c4/6014f854e9dd715e38dd61d3bd50b905e5f5af
@@ -0,0 +1,95 @@
+Return-Path: <cworth@cworth.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 900B54196F2\r
+       for <notmuch@notmuchmail.org>; Tue, 27 Apr 2010 08:12:59 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.89\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.89 tagged_above=-999 required=5\r
+       tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, T_MIME_NO_TEXT=0.01]\r
+       autolearn=ham\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id k8V01wTbfqhL; Tue, 27 Apr 2010 08:12:58 -0700 (PDT)\r
+Received: from yoom.home.cworth.org (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id C4781431FC1;\r
+       Tue, 27 Apr 2010 08:12:58 -0700 (PDT)\r
+Received: by yoom.home.cworth.org (Postfix, from userid 1000)\r
+       id 6602125400A; Tue, 27 Apr 2010 08:12:58 -0700 (PDT)\r
+From: Carl Worth <cworth@cworth.org>\r
+To: Sebastian Spaeth <Sebastian@SSpaeth.de>,\r
+       Notmuch developer list <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH] Rename already used counter var i\r
+In-Reply-To: <1272373045-29268-1-git-send-email-Sebastian@SSpaeth.de>\r
+References: <87tyqxmdw6.fsf@yoom.home.cworth.org>\r
+       <1272373045-29268-1-git-send-email-Sebastian@SSpaeth.de>\r
+User-Agent: Notmuch/0.2-251-g8514e59 (http://notmuchmail.org) Emacs/23.1.1\r
+       (i486-pc-linux-gnu)\r
+Date: Tue, 27 Apr 2010 08:12:46 -0700\r
+Message-ID: <87r5m1lyj5.fsf@yoom.home.cworth.org>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 27 Apr 2010 15:12:59 -0000\r
+\r
+--=-=-=\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Tue, 27 Apr 2010 14:57:25 +0200, Sebastian Spaeth <Sebastian@SSpaeth.de>=\r
+ wrote:\r
+> From: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>\r
+> i is already used in a for loop at this point, so using i here again\r
+> broke notmuch-reply (it would just hang). Use j instead of i here.\r
+\r
+Thanks for the fix.\r
+\r
+>  Aneesh noticed this bug and provided a fix for it. IMO it warrants a 0.3=\r
+.1\r
+>  release. notmuch-reply hanging indefinitely is not going to make grumpy\r
+>  editors happy.\r
+\r
+\r
+Definitely.\r
+\r
+For a point release like 0.3.1 I'm going to insist on a test case that\r
+demonstrates each regression being fixed. Does someone know what it\r
+takes to make a mail trigger this bug?\r
+\r
+>  Also despite a documentation blurb above the main snippet of\r
+>  code, I find it pretty much black magic what is being done here. But the=\r
+n=20\r
+>  I don't really know C....\r
+\r
+I find it pretty much black magic too. I rewrote one piece of\r
+black-magic code late last night when we noticed it was causing crashes\r
+and valgrind was complaining. I'll dive in and give this chunk of code\r
+some similar treatment.\r
+\r
+=2DCarl\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.10 (GNU/Linux)\r
+\r
+iD8DBQFL1v7u6JDdNq8qSWgRAgQGAJ9xJh55o3PALeJrCiUcsogvrZ6MiQCfcFbg\r
+S99Z/jI645zQTcMmuM60yiE=\r
+=LhWS\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r