Re: [PATCH 1/2] contrib: pick: add thread based utility functions

diff --git a/35/f11122d585e5bc8c73844da333ec225d586917 b/35/f11122d585e5bc8c73844da333ec225d586917
new file mode 100644 (file)
index 0000000..dc17cf6
--- /dev/null
+++ b/35/f11122d585e5bc8c73844da333ec225d586917
@@ -0,0 +1,82 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 122F5429E4F\r
+       for <notmuch@notmuchmail.org>; Sat,  1 Jun 2013 05:37:04 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id ZlSbI5GFXtT5 for <notmuch@notmuchmail.org>;\r
+       Sat,  1 Jun 2013 05:36:56 -0700 (PDT)\r
+Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 2B17A431FDE\r
+       for <notmuch@notmuchmail.org>; Sat,  1 Jun 2013 05:36:56 -0700 (PDT)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id r51CasLs023810;\r
+       Sat, 1 Jun 2013 09:36:54 -0300\r
+Received: from remotemail by tesseract.cs.unb.ca with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1Uil3G-0003yQ-9C; Sat, 01 Jun 2013 09:36:54 -0300\r
+Received: (nullmailer pid 12141 invoked by uid 1000);\r
+       Sat, 01 Jun 2013 12:36:52 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/2] contrib: pick: add thread based utility functions\r
+In-Reply-To: <878v30kh8p.fsf@qmul.ac.uk>\r
+References: <1354970914-18342-1-git-send-email-markwalters1009@gmail.com>\r
+       <1354970914-18342-2-git-send-email-markwalters1009@gmail.com>\r
+       <87fvxswgff.fsf@zancas.localnet> <878v30kh8p.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.15.2+69~g360c3c8 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 01 Jun 2013 09:36:51 -0300\r
+Message-ID: <87ppw6ypln.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 01 Jun 2013 12:37:04 -0000\r
+\r
+Mark Walters <markwalters1009@gmail.com> writes:\r
+>\r
+> David Bremner <david@tethera.net> writes:\r
+>\r
+>\r
+>> More importantly, in emacs 24.3 I get an infinite loop when trying to\r
+>> evaluate the update notmuch-pick.el. \r
+>\r
+> I think this is just stupidity on my part: it should be a defun rather\r
+> than a defmacro. Would you be able to test that (or I can send a new\r
+> version if you prefer)?\r
+>\r
+\r
+Yes, changing that defmacro to a defun fixes the loop.\r
+\r
+I load pick as follows\r
+\r
+    (add-to-list 'load-path\r
+                 (expand-file-name "~/software/upstream/notmuch/contrib/notmuch-pick"))\r
+    (require 'notmuch-pick nil t)\r
+\r
+\r
+I'll need another version in any case, since it doesn't apply to master\r
+anymore, but hold off for a review of 2/2.\r
+\r
+d\r